From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Ying Han <yinghan@google.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Mel Gorman <mel@csn.ul.ie>, Rik van Riel <riel@redhat.com>,
Minchan Kim <minchan.kim@gmail.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH V2 1/2] count the soft_limit reclaim in global background reclaim
Date: Tue, 29 Mar 2011 10:29:00 +0900 (JST) [thread overview]
Message-ID: <20110329102926.C084.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <1301356270-26859-2-git-send-email-yinghan@google.com>
> @@ -2320,6 +2324,8 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
> int end_zone = 0; /* Inclusive. 0 = ZONE_DMA */
> unsigned long total_scanned;
> struct reclaim_state *reclaim_state = current->reclaim_state;
> + unsigned long nr_soft_reclaimed;
> + unsigned long nr_soft_scanned;
> struct scan_control sc = {
> .gfp_mask = GFP_KERNEL,
> .may_unmap = 1,
> @@ -2409,11 +2415,15 @@ loop_again:
>
> sc.nr_scanned = 0;
>
> + nr_soft_scanned = 0;
> /*
> * Call soft limit reclaim before calling shrink_zone.
> - * For now we ignore the return value
> */
> - mem_cgroup_soft_limit_reclaim(zone, order, sc.gfp_mask);
> + nr_soft_reclaimed = mem_cgroup_soft_limit_reclaim(zone,
> + order, sc.gfp_mask,
> + &nr_soft_scanned);
> + sc.nr_reclaimed += nr_soft_reclaimed;
> + total_scanned += nr_soft_scanned;
>
> /*
> * We put equal pressure on every zone, unless
Thank you.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-29 1:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 23:51 [PATCH V2 0/2] Reduce reclaim from per-zone LRU in global kswapd Ying Han
2011-03-28 23:51 ` [PATCH V2 1/2] count the soft_limit reclaim in global background reclaim Ying Han
2011-03-29 1:00 ` KAMEZAWA Hiroyuki
2011-03-29 1:29 ` KOSAKI Motohiro [this message]
2011-03-28 23:51 ` [PATCH V2 2/2] add stats to monitor soft_limit reclaim Ying Han
2011-03-29 1:22 ` KAMEZAWA Hiroyuki
2011-03-29 4:38 ` Ying Han
2011-03-29 2:32 ` Daisuke Nishimura
2011-03-29 4:55 ` Ying Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110329102926.C084.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=riel@redhat.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox