From: Michal Hocko <mhocko@suse.cz>
To: Ying Han <yinghan@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: cgroup: real meaning of memory.usage_in_bytes
Date: Wed, 23 Mar 2011 15:26:45 +0100 [thread overview]
Message-ID: <20110323142645.GB15474@tiehlicka.suse.cz> (raw)
In-Reply-To: <AANLkTi=2t_tL=Vt4athAyQ1tDhLDGpqtmu-iAOjdbPBJ@mail.gmail.com>
On Tue 22-03-11 10:06:27, Ying Han wrote:
> On Tue, Mar 22, 2011 at 12:35 AM, Michal Hocko <mhocko@suse.cz> wrote:
> > On Mon 21-03-11 10:22:41, Ying Han wrote:
> > [...]
> >>
> >> Michal,
> >>
> >> Can you help to post the test result after applying the patch?
> >
> > The result of the LTP test is:
> > TEST 4: MEMORY CONTROLLER TESTING
> > RUNNING SETUP.....
> > WARN:/dev/memctl already exist..overwriting
> > Cleanup called
> > TEST STARTED: Please avoid using system while this test executes
> > memory usage from memory.usage_in_bytes= 62955520
> > memory usage from memory.stat= 62955520
> > TINFO ? Memory Resource Controller: stat check test passes first run
> > Test continues to run the second step.
> > memory usage from memory.usage_in_bytes= 78643200
> > memory usage from memory.stat=78643200
> > TPASS ? Memory Resource Controller: stat check test PASSED
> > Memory Resource Controller test executed successfully.
> > Cleanup called
[...]
> Thanks Michal for fixing it up. Regardless of the performance
> overhead, the change make sense to me.
As you can see in the other email in this thread the patch is not 100%
correct because it doesn't consider batched uncharges which are stored
in the task_struct. Make it 100% correct would be harder and probably
not worth the overhead. Daisuke Nishimura is working on the
documentation update patch which will most likely describe that
usage_in_bytes is not exactly rss+cache and that nobody should rely on
it.
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-03-23 14:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 15:25 Michal Hocko
2011-03-18 15:29 ` Michal Hocko
2011-03-21 9:34 ` Michal Hocko
2011-03-21 10:24 ` [PATCH] memcg: consider per-cpu stock reserves when returning RES_USAGE for _MEM Michal Hocko
2011-03-22 0:10 ` KAMEZAWA Hiroyuki
2011-03-22 1:47 ` Daisuke Nishimura
2011-03-22 7:31 ` Michal Hocko
2011-03-23 0:27 ` Daisuke Nishimura
2011-03-23 4:35 ` KAMEZAWA Hiroyuki
2011-03-27 23:55 ` Daisuke Nishimura
2011-03-28 4:25 ` [PATCH] memcg: update documentation to describe usage_in_bytes Daisuke Nishimura
2011-03-28 7:43 ` Michal Hocko
2011-03-28 9:11 ` KAMEZAWA Hiroyuki
2011-03-28 9:48 ` Michal Hocko
2011-03-28 10:31 ` KAMEZAWA Hiroyuki
2011-03-29 1:15 ` [PATCH v2] " Daisuke Nishimura
2011-03-29 1:24 ` KAMEZAWA Hiroyuki
2011-03-29 7:21 ` Michal Hocko
2011-04-19 12:14 ` Michal Hocko
2011-04-19 23:24 ` Daisuke Nishimura
2011-03-21 17:22 ` cgroup: real meaning of memory.usage_in_bytes Ying Han
2011-03-22 7:35 ` Michal Hocko
2011-03-22 17:06 ` Ying Han
2011-03-23 14:26 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323142645.GB15474@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox