From: Herbert Xu <herbert@gondor.apana.org.au>
To: George Spelvin <linux@horizon.com>
Cc: hughd@google.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mpm@selenic.com, penberg@cs.helsinki.fi
Subject: Re: [PATCH 1/8] drivers/random: Cache align ip_random better
Date: Tue, 22 Mar 2011 17:03:50 +0800 [thread overview]
Message-ID: <20110322090350.GA23736@gondor.apana.org.au> (raw)
In-Reply-To: <20110316194542.22530.qmail@science.horizon.com>
On Wed, Mar 16, 2011 at 03:45:42PM -0400, George Spelvin wrote:
>
> > Ah, now you come clean! Yes, it does feel neater to me too;
> > but I doubt that would be sufficient justification by itself.
>
> It took both factors to make it worth it to me. The real reason was:
> 1) Neater
> 2) Definitely not slower
> 3) Maybe a tiny bit faster
> Conclusion: do it.
I'm with Hugh on this, the justification seems pretty weak.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-22 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 0:20 George Spelvin
2011-03-16 2:54 ` Matt Mackall
2011-03-16 6:24 ` Pekka Enberg
2011-03-16 17:17 ` Hugh Dickins
2011-03-16 18:10 ` George Spelvin
2011-03-16 18:42 ` Hugh Dickins
2011-03-16 19:45 ` George Spelvin
2011-03-22 9:03 ` Herbert Xu [this message]
2011-03-16 18:23 ` Matt Mackall
2011-03-16 19:26 ` Eric Dumazet
2011-03-16 19:55 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110322090350.GA23736@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@horizon.com \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox