From: "xianai@nju.edu.cn" <xianai@nju.edu.cn>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Izik Eidus <ieidus@redhat.com>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Andrea Arcangeli <aarcange@redhat.com>,
Chris Wright <chrisw@sous-sol.org>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ksm: add vm_stat and meminfo entry to reflect pte mapping to ksm pages
Date: Fri, 18 Mar 2011 14:44:27 +0800 [thread overview]
Message-ID: <201103181444.27725.xianai@nju.edu.cn> (raw)
In-Reply-To: <1298946108.9138.1173.camel@nimitz>
>On Tuesday 01 March 2011, at 10:21:48, <Dave Hansen <dave@linux.vnet.ibm.com>> wrote
> On Sat, 2011-02-26 at 22:56 +0800, Nai Xia wrote
> > @@ -904,6 +905,10 @@ static int try_to_merge_one_page(struct vm_area_struct
> > *vma,
> > */
> > set_page_stable_node(page, NULL);
> > mark_page_accessed(page);
> > + if (mapcount)
> > + add_zone_page_state(page_zone(page),
> > + NR_KSM_PAGES_SHARING,
> > + mapcount);
> > err = 0;
> > } else if (pages_identical(page, kpage))
> > err = replace_page(vma, page, kpage, orig_pte);
>
> If you're going to store this per-zone, does it make sense to have it
> show up in /proc/zoneinfo? meminfo's also getting pretty porky these
> days, so I almost wonder if it should stay in zoneinfo only.
Yes, thanks for pointing out, I will fix it soon. And sorry for the late
response,there was a bug in my mail client which prevents this mail from being
filtered out.
Nai
>
> -- Dave
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-18 6:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 14:56 Nai Xia
2011-03-01 2:21 ` Dave Hansen
2011-03-18 6:44 ` xianai [this message]
2011-03-01 23:41 ` Andrew Morton
2011-03-18 7:16 ` Nai Xia
2011-03-02 22:31 ` Andrew Morton
2011-03-18 7:29 ` Nai Xia
2011-03-18 22:40 ` Hugh Dickins
2011-03-19 14:55 ` Nai Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103181444.27725.xianai@nju.edu.cn \
--to=xianai@nju.edu.cn \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=ieidus@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox