From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Stephen Wilson <wilsons@start.ca>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Rik van Riel <riel@redhat.com>,
Roland McGrath <roland@redhat.com>,
Matt Mackall <mpm@selenic.com>,
David Rientjes <rientjes@google.com>,
Nick Piggin <npiggin@kernel.dk>,
Andrea Arcangeli <aarcange@redhat.com>,
Mel Gorman <mel@csn.ul.ie>, Ingo Molnar <mingo@elte.hu>,
Michel Lespinasse <walken@google.com>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] proc: make check_mem_permission() return an mm_struct on success
Date: Wed, 9 Mar 2011 15:20:16 +0900 (JST) [thread overview]
Message-ID: <20110309151900.0403.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <1299631343-4499-6-git-send-email-wilsons@start.ca>
> This change allows us to take advantage of access_remote_vm(), which in turn
> enables a secure mem_write() implementation.
>
> The previous implementation of mem_write() was insecure since the target task
> could exec a setuid-root binary between the permission check and the actual
> write. Holding a reference to the target mm_struct eliminates this
> vulnerability.
>
> Signed-off-by: Stephen Wilson <wilsons@start.ca>
OK, I like this idea. So, I suppose you will resend newer version as applied Al's
comment and I'll be able to ack this.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-09 6:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 0:42 [PATCH 0/6] enable writing to /proc/pid/mem Stephen Wilson
2011-03-09 0:42 ` [PATCH 1/6] mm: use mm_struct to resolve gate vma's in __get_user_pages Stephen Wilson
2011-03-09 5:19 ` KOSAKI Motohiro
2011-03-09 6:06 ` Al Viro
2011-03-09 12:38 ` Stephen Wilson
2011-03-09 0:42 ` [PATCH 2/6] mm: factor out main logic of access_process_vm Stephen Wilson
2011-03-09 0:42 ` [PATCH 3/6] mm: implement access_remote_vm Stephen Wilson
2011-03-09 0:42 ` [PATCH 4/6] proc: disable mem_write after exec Stephen Wilson
2011-03-09 5:22 ` KOSAKI Motohiro
2011-03-09 0:42 ` [PATCH 5/6] proc: make check_mem_permission() return an mm_struct on success Stephen Wilson
2011-03-09 6:20 ` KOSAKI Motohiro [this message]
2011-03-09 0:42 ` [PATCH 6/6] proc: enable writing to /proc/pid/mem Stephen Wilson
2011-03-09 1:30 ` [PATCH 0/6] " Al Viro
2011-03-09 2:15 ` Stephen Wilson
2011-03-09 2:33 ` Al Viro
2011-03-09 2:47 ` Stephen Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309151900.0403.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=npiggin@kernel.dk \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=roland@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
--cc=wilsons@start.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox