From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id 36EEF8D0039 for ; Mon, 7 Mar 2011 04:41:45 -0500 (EST) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 353223EE0C5 for ; Mon, 7 Mar 2011 18:41:37 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 1BEBA45DE5A for ; Mon, 7 Mar 2011 18:41:37 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id EF0A245DE56 for ; Mon, 7 Mar 2011 18:41:36 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id DA7E0E08006 for ; Mon, 7 Mar 2011 18:41:36 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.240.81.145]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id A5B78E08002 for ; Mon, 7 Mar 2011 18:41:36 +0900 (JST) Date: Mon, 7 Mar 2011 18:35:16 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCHv2 08/24] sys_swapon: move setting of error nearer use Message-Id: <20110307183516.45ca82ae.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1299343345-3984-9-git-send-email-cesarb@cesarb.net> References: <1299343345-3984-1-git-send-email-cesarb@cesarb.net> <1299343345-3984-9-git-send-email-cesarb@cesarb.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Cesar Eduardo Barros Cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , Minchan Kim , Jens Axboe , linux-kernel@vger.kernel.org, Eric B Munson On Sat, 5 Mar 2011 13:42:09 -0300 Cesar Eduardo Barros wrote: > Move the setting of the error variable nearer the goto in a few places. > > Avoids calling PTR_ERR() if not IS_ERR() in two places, and makes the > error condition more explicit in two other places. > > Signed-off-by: Cesar Eduardo Barros > Tested-by: Eric B Munson > Acked-by: Eric B Munson Reviewed-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org