From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 6900A8D0039 for ; Mon, 7 Mar 2011 04:31:18 -0500 (EST) Received: from m1.gw.fujitsu.co.jp (unknown [10.0.50.71]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 11E7A3EE0C1 for ; Mon, 7 Mar 2011 18:31:15 +0900 (JST) Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id E9C8045DE5B for ; Mon, 7 Mar 2011 18:31:14 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id D088E45DE54 for ; Mon, 7 Mar 2011 18:31:14 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 8FF07E08002 for ; Mon, 7 Mar 2011 18:31:14 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.240.81.133]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 441201DB804A for ; Mon, 7 Mar 2011 18:31:14 +0900 (JST) Date: Mon, 7 Mar 2011 18:24:51 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCHv2 03/24] sys_swapon: do not depend on "type" after allocation Message-Id: <20110307182451.23b711ad.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1299343345-3984-4-git-send-email-cesarb@cesarb.net> References: <1299343345-3984-1-git-send-email-cesarb@cesarb.net> <1299343345-3984-4-git-send-email-cesarb@cesarb.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Cesar Eduardo Barros Cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , Minchan Kim , Jens Axboe , linux-kernel@vger.kernel.org, Eric B Munson On Sat, 5 Mar 2011 13:42:04 -0300 Cesar Eduardo Barros wrote: > Within sys_swapon, after the swap_info entry has been allocated, we > always have type == p->type and swap_info[type] == p. Use this fact to > reduce the dependency on the "type" local variable within the function, > as a preparation to move the allocation of the swap_info entry to a > separate function. > > Signed-off-by: Cesar Eduardo Barros > Tested-by: Eric B Munson > Acked-by: Eric B Munson > --- Reviewed-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org