From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andrey Vagin <avagin@openvz.org>
Cc: kosaki.motohiro@jp.fujitsu.com,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: skip zombie in OOM-killer
Date: Sun, 6 Mar 2011 19:37:46 +0900 (JST) [thread overview]
Message-ID: <20110306193519.49DD.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <1299286307-4386-1-git-send-email-avagin@openvz.org>
> When we check that task has flag TIF_MEMDIE, we forgot check that
> it has mm. A task may be zombie and a parent may wait a memor.
>
> v2: Check that task doesn't have mm one time and skip it immediately
>
> Signed-off-by: Andrey Vagin <avagin@openvz.org>
This seems incorrect. Do you have a reprodusable testcasae?
Your patch only care thread group leader state, but current code
care all thread in the process. Please look at oom_badness() and
find_lock_task_mm().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-06 10:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 0:51 Andrey Vagin
2011-03-06 2:44 ` David Rientjes
2011-03-06 10:37 ` KOSAKI Motohiro [this message]
2011-03-06 22:03 ` David Rientjes
2011-03-07 11:55 ` Andrew Vagin
2011-03-07 20:36 ` David Rientjes
2011-03-07 21:52 ` Andrew Morton
2011-03-07 23:43 ` David Rientjes
2011-03-08 1:24 ` KOSAKI Motohiro
2011-03-08 2:07 ` KOSAKI Motohiro
2011-03-08 2:10 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110306193519.49DD.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox