From: Eric B Munson <emunson@mgebm.net>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Petr Holasek <pholasek@redhat.com>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Wu Fengguang <fengguang.wu@intel.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] hugetlbfs: correct handling of negative input to /proc/sys/vm/nr_hugepages
Date: Thu, 24 Feb 2011 13:20:33 -0500 [thread overview]
Message-ID: <20110224182033.GA30387@mgebm.net> (raw)
In-Reply-To: <20110224094912.GO15652@csn.ul.ie>
[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]
On Thu, 24 Feb 2011, Mel Gorman wrote:
> On Wed, Feb 23, 2011 at 04:18:18PM -0800, Andrew Morton wrote:
> > On Tue, 22 Feb 2011 10:02:36 +0000
> > Mel Gorman <mel@csn.ul.ie> wrote:
> >
> > > On Mon, Feb 21, 2011 at 04:47:49PM +0100, Petr Holasek wrote:
> > > > When user insert negative value into /proc/sys/vm/nr_hugepages it will result
> > > > in the setting a random number of HugePages in system (can be easily showed
> > > > at /proc/meminfo output).
> > >
> > > I bet you a shiny penny that the value of HugePages becomes the maximum
> > > number that could be allocated by the system at the time rather than a
> > > random value.
> >
> > That seems to be the case from my reading. In which case the patch
> > removes probably-undocumented and possibly-useful existing behavior.
> >
>
> It's not proof that no one does this but I'm not aware of any documentation
> related to hugetlbfs that recommends writing negative values to take advantage
> of this side-effect. It's more likely they simply wrote a very large number
> to nr_hugepages if they wanted "as many hugepages as possible" as it makes
> more intuitive sense than asking for a negative amount of pages. hugeadm at
> least is not depending on this behaviour AFAIK.
That is correct, hugeadm never writes negative values to huge page pool sizes.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2011-02-24 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 15:47 Petr Holasek
2011-02-22 0:30 ` Naoya Horiguchi
2011-02-22 10:02 ` Mel Gorman
2011-02-24 0:18 ` Andrew Morton
2011-02-24 9:49 ` Mel Gorman
2011-02-24 18:20 ` Eric B Munson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224182033.GA30387@mgebm.net \
--to=emunson@mgebm.net \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=pholasek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox