From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id CAFBF8D0039 for ; Wed, 23 Feb 2011 19:19:07 -0500 (EST) Date: Wed, 23 Feb 2011 16:18:18 -0800 From: Andrew Morton Subject: Re: [PATCH] hugetlbfs: correct handling of negative input to /proc/sys/vm/nr_hugepages Message-Id: <20110223161818.9876cc10.akpm@linux-foundation.org> In-Reply-To: <20110222100235.GA15652@csn.ul.ie> References: <1298303270-3184-1-git-send-email-pholasek@redhat.com> <20110222100235.GA15652@csn.ul.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Petr Holasek , linux-kernel@vger.kernel.org, Andi Kleen , Naoya Horiguchi , Wu Fengguang , linux-mm@kvack.org On Tue, 22 Feb 2011 10:02:36 +0000 Mel Gorman wrote: > On Mon, Feb 21, 2011 at 04:47:49PM +0100, Petr Holasek wrote: > > When user insert negative value into /proc/sys/vm/nr_hugepages it will result > > in the setting a random number of HugePages in system (can be easily showed > > at /proc/meminfo output). > > I bet you a shiny penny that the value of HugePages becomes the maximum > number that could be allocated by the system at the time rather than a > random value. That seems to be the case from my reading. In which case the patch removes probably-undocumented and possibly-useful existing behavior. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org