From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 7DD798D0039 for ; Thu, 17 Feb 2011 11:12:23 -0500 (EST) Received: from m1.gw.fujitsu.co.jp (unknown [10.0.50.71]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 1E4333EE0BC for ; Fri, 18 Feb 2011 01:12:21 +0900 (JST) Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id F05A245DE5C for ; Fri, 18 Feb 2011 01:12:20 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id C827745DE58 for ; Fri, 18 Feb 2011 01:12:20 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id B92D6E78002 for ; Fri, 18 Feb 2011 01:12:20 +0900 (JST) Received: from m107.s.css.fujitsu.com (m107.s.css.fujitsu.com [10.249.87.107]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 80E651DB8047 for ; Fri, 18 Feb 2011 01:12:20 +0900 (JST) Date: Fri, 18 Feb 2011 01:06:03 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH v5 3/4] Reclaim invalidated page ASAP Message-Id: <20110218010603.46152945.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <973e9f9bf2006923b600be0c28cedce777a2cf2a.1297940291.git.minchan.kim@gmail.com> References: <973e9f9bf2006923b600be0c28cedce777a2cf2a.1297940291.git.minchan.kim@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , Steven Barrett , Ben Gamari , Peter Zijlstra , Rik van Riel , Mel Gorman , KOSAKI Motohiro , Wu Fengguang , Johannes Weiner , Nick Piggin , Andrea Arcangeli , Balbir Singh On Fri, 18 Feb 2011 00:08:21 +0900 Minchan Kim wrote: > invalidate_mapping_pages is very big hint to reclaimer. > It means user doesn't want to use the page any more. > So in order to prevent working set page eviction, this patch > move the page into tail of inactive list by PG_reclaim. > > Please, remember that pages in inactive list are working set > as well as active list. If we don't move pages into inactive list's > tail, pages near by tail of inactive list can be evicted although > we have a big clue about useless pages. It's totally bad. > > Now PG_readahead/PG_reclaim is shared. > fe3cba17 added ClearPageReclaim into clear_page_dirty_for_io for > preventing fast reclaiming readahead marker page. > > In this series, PG_reclaim is used by invalidated page, too. > If VM find the page is invalidated and it's dirty, it sets PG_reclaim > to reclaim asap. Then, when the dirty page will be writeback, > clear_page_dirty_for_io will clear PG_reclaim unconditionally. > It disturbs this serie's goal. > > I think it's okay to clear PG_readahead when the page is dirty, not > writeback time. So this patch moves ClearPageReadahead. > In v4, ClearPageReadahead in set_page_dirty has a problem which is reported > by Steven Barrett. It's due to compound page. Some driver(ex, audio) calls > set_page_dirty with compound page which isn't on LRU. but my patch does > ClearPageRelcaim on compound page. In non-CONFIG_PAGEFLAGS_EXTENDED, it breaks > PageTail flag. > > I think it doesn't affect THP and pass my test with THP enabling > but Cced Andrea for double check. > > Reported-by: Steven Barrett > Reviewed-by: Johannes Weiner > Acked-by: Rik van Riel > Acked-by: Mel Gorman > Cc: Wu Fengguang > Cc: KOSAKI Motohiro > Cc: Nick Piggin > Cc: Andrea Arcangeli > Signed-off-by: Minchan Kim Reviewed-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org