From: Randy Dunlap <randy.dunlap@oracle.com>
To: akpm@linux-foundation.org, rmthomas@sciolus.org,
driverdevel <devel@driverdev.osuosl.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, gregkh <greg@kroah.com>
Subject: [PATCH -mmotm] staging/easycap: fix build when SND is not enabled
Date: Sat, 5 Feb 2011 09:36:32 -0800 [thread overview]
Message-ID: <20110205093632.b76be846.randy.dunlap@oracle.com> (raw)
In-Reply-To: <201102042349.p14NnQEm025834@imap1.linux-foundation.org>
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix easycap build when CONFIG_SOUND is enabled but CONFIG_SND is
not enabled.
These functions are only built when CONFIG_SND is enabled, so the
driver should depend on SND.
This means that having SND enabled is required for the (obsolete)
EASYCAP_OSS config option.
drivers/built-in.o: In function `easycap_usb_disconnect':
easycap_main.c:(.text+0x2aba20): undefined reference to `snd_card_free'
drivers/built-in.o: In function `easycap_alsa_probe':
(.text+0x2b784b): undefined reference to `snd_card_create'
drivers/built-in.o: In function `easycap_alsa_probe':
(.text+0x2b78fb): undefined reference to `snd_pcm_new'
drivers/built-in.o: In function `easycap_alsa_probe':
(.text+0x2b7916): undefined reference to `snd_pcm_set_ops'
drivers/built-in.o: In function `easycap_alsa_probe':
(.text+0x2b795b): undefined reference to `snd_card_register'
drivers/built-in.o: In function `easycap_alsa_probe':
(.text+0x2b79d8): undefined reference to `snd_card_free'
drivers/built-in.o: In function `easycap_alsa_probe':
(.text+0x2b7a78): undefined reference to `snd_card_free'
drivers/built-in.o: In function `easycap_alsa_complete':
(.text+0x2b7e68): undefined reference to `snd_pcm_period_elapsed'
drivers/built-in.o:(.data+0x2cae8): undefined reference to `snd_pcm_lib_ioctl'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: R.M. Thomas <rmthomas@sciolus.org>
---
drivers/staging/easycap/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- mmotm-2011-0204-1515.orig/drivers/staging/easycap/Kconfig
+++ mmotm-2011-0204-1515/drivers/staging/easycap/Kconfig
@@ -1,6 +1,6 @@
config EASYCAP
tristate "EasyCAP USB ID 05e1:0408 support"
- depends on USB && VIDEO_DEV && SOUND
+ depends on USB && VIDEO_DEV && SND
---help---
This is an integrated audio/video driver for EasyCAP cards with
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-05 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 23:15 mmotm 2011-02-04-15-15 uploaded akpm
2011-02-05 2:31 ` mmotm 2011-02-04-15-15 uploaded (printk DEFAULT_MESSAGE_LOGLEVEL) Randy Dunlap
2011-02-05 2:34 ` mmotm 2011-02-04-15-15 uploaded Stephen Rothwell
2011-02-05 2:43 ` Andrew Morton
2011-02-05 10:44 ` Johannes Weiner
2011-02-05 11:40 ` Johannes Weiner
2011-02-05 2:38 ` mmotm 2011-02-04-15-15 uploaded (page_cgroup.h) Randy Dunlap
2011-02-05 9:04 ` [patch fixup] memcg: remove direct page_cgroup-to-page pointer fix Johannes Weiner
2011-02-05 18:04 ` Randy Dunlap
2011-02-05 17:36 ` Randy Dunlap [this message]
2011-02-06 7:25 ` [PATCH -mmotm] staging/easycap: fix build when SND is not enabled Tomas Winkler
2011-02-06 16:01 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110205093632.b76be846.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rmthomas@sciolus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox