From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 5F6308D0039 for ; Thu, 27 Jan 2011 18:55:40 -0500 (EST) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 268A93EE0B3 for ; Fri, 28 Jan 2011 08:55:38 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 07EFC45DE57 for ; Fri, 28 Jan 2011 08:55:38 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id E58DE45DE4D for ; Fri, 28 Jan 2011 08:55:37 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id D972EE08001 for ; Fri, 28 Jan 2011 08:55:37 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id A5AC91DB8037 for ; Fri, 28 Jan 2011 08:55:37 +0900 (JST) Date: Fri, 28 Jan 2011 08:49:28 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [patch 3/3] memcg: never OOM when charging huge pages Message-Id: <20110128084928.8ffb68e1.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20110128084540.3a5511ba.nishimura@mxp.nes.nec.co.jp> References: <20110121153431.191134dd.kamezawa.hiroyu@jp.fujitsu.com> <20110121154430.70d45f15.kamezawa.hiroyu@jp.fujitsu.com> <20110127103438.GC2401@cmpxchg.org> <20110127134703.GB14309@cmpxchg.org> <20110128084540.3a5511ba.nishimura@mxp.nes.nec.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Daisuke Nishimura Cc: Johannes Weiner , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "balbir@linux.vnet.ibm.com" , "akpm@linux-foundation.org" List-ID: On Fri, 28 Jan 2011 08:45:40 +0900 Daisuke Nishimura wrote: > On Thu, 27 Jan 2011 14:47:03 +0100 > Johannes Weiner wrote: > > > Huge page coverage should obviously have less priority than the > > continued execution of a process. > > > > Never kill a process when charging it a huge page fails. Instead, > > give up after the first failed reclaim attempt and fall back to > > regular pages. > > > > Signed-off-by: Johannes Weiner > > --- > > mm/memcontrol.c | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 17c4e36..2945649 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -1890,6 +1890,13 @@ static int __mem_cgroup_try_charge(struct mm_struct *mm, > > int csize = max(CHARGE_SIZE, (unsigned long) page_size); > > > > /* > > + * Do not OOM on huge pages. Fall back to regular pages after > > + * the first failed reclaim attempt. > > + */ > > + if (page_size > PAGE_SIZE) > > + oom = false; > > + > > + /* > > * Unlike gloval-vm's OOM-kill, we're not in memory shortage > > * in system level. So, allow to go ahead dying process in addition to > > * MEMDIE process. > > -- > > 1.7.3.5 > > > __mem_cgroup_try_charge() has "oom" switch already, so I prefer making callers > use the switch properly by themselves. > Okay, will do. -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org