From: Andrew Morton <akpm@linux-foundation.org>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Yoichi Yuasa <yuasa@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix build error when CONFIG_SWAP is not set
Date: Mon, 24 Jan 2011 12:44:12 -0800 [thread overview]
Message-ID: <20110124124412.69a7c814.akpm@linux-foundation.org> (raw)
In-Reply-To: <4D3DD366.8000704@mvista.com>
On Mon, 24 Jan 2011 22:30:46 +0300
Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> Hello.
>
> Yoichi Yuasa wrote:
>
> > In file included from
> > linux-2.6/arch/mips/include/asm/tlb.h:21,
> > from mm/pgtable-generic.c:9:
> > include/asm-generic/tlb.h: In function 'tlb_flush_mmu':
> > include/asm-generic/tlb.h:76: error: implicit declaration of function
> > 'release_pages'
> > include/asm-generic/tlb.h: In function 'tlb_remove_page':
> > include/asm-generic/tlb.h:105: error: implicit declaration of function
> > 'page_cache_release'
> > make[1]: *** [mm/pgtable-generic.o] Error 1
> >
> > Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
> [...]
>
> > diff --git a/include/linux/swap.h b/include/linux/swap.h
> > index 4d55932..92c1be6 100644
> > --- a/include/linux/swap.h
> > +++ b/include/linux/swap.h
> > @@ -8,6 +8,7 @@
> > #include <linux/memcontrol.h>
> > #include <linux/sched.h>
> > #include <linux/node.h>
> > +#include <linux/pagemap.h>
>
> Hm, if the errors are in <asm-generic/tlb.h>, why add #include in
> <linux/swap.h>?
>
The build error is caused by macros which are defined in swap.h.
I worry about the effects of the patch - I don't know which of swap.h
and pagemap.h is the "innermost" header file. There's potential for
new build errors due to strange inclusion graphs.
err, there's also this, in swap.h:
/* only sparc can not include linux/pagemap.h in this file
* so leave page_cache_release and release_pages undeclared... */
It would be safer to convert free_page_and_swap_cache() and
free_pages_and_swap_cache() into out-of-line C functions. Or to
explicitly include pagemap.h into the offending .c files.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-24 20:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 12:08 Yoichi Yuasa
2011-01-24 13:15 ` Ralf Baechle
2011-01-24 19:30 ` Sergei Shtylyov
2011-01-24 20:44 ` Andrew Morton [this message]
2011-01-24 21:07 ` Sam Ravnborg
2011-01-25 6:24 ` Geert Uytterhoeven
2011-01-25 6:33 ` Andrew Morton
2011-01-25 7:41 ` Sam Ravnborg
2011-01-25 12:41 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110124124412.69a7c814.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=sshtylyov@mvista.com \
--cc=yuasa@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox