From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>, Mel Gorman <mel@csn.ul.ie>,
Christoph Lameter <cl@linux-foundation.org>,
Huang Ying <ying.huang@intel.com>,
Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>,
tony.luck@intel.com, LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 3/7] remove putback_lru_pages() in hugepage migration context
Date: Fri, 21 Jan 2011 19:00:28 +0900 [thread overview]
Message-ID: <20110121100028.GA11102@spritzera.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <AANLkTikOdCzhsw3_JQtbJOmA8CRm2hCZEY0LLw5uYtmM@mail.gmail.com>
Hi,
On Fri, Jan 21, 2011 at 03:40:35PM +0900, Minchan Kim wrote:
> Hello,
>
> On Fri, Jan 21, 2011 at 3:28 PM, Naoya Horiguchi
> <n-horiguchi@ah.jp.nec.com> wrote:
> > This putback_lru_pages() is inserted at cf608ac19c to allow
> > memory compaction to count the number of migration failed pages.
> >
> > But we should not do it for a hugepage because page->lru of a hugepage
> > is used differently from that of a normal page:
> >
> > in-use hugepage : page->lru is unlinked,
> > free hugepage : page->lru is linked to the free hugepage list,
> >
> > so putting back hugepages to LRU lists collapses this rule.
> > We just drop this change (without any impact on memory compaction.)
> >
> > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> > Cc: Minchan Kim <minchan.kim@gmail.com>
>
> As I said previously, It seems mistake during patch merge.
> I didn't add it in my original patch. You can see my final patch.
> https://lkml.org/lkml/2010/8/24/248
OK.
> Anyway, I realized it recently so I sent the patch to Andrew.
> Could you see this one?
> https://lkml.org/lkml/2011/1/20/241
This patch seems not to change hugepage soft offline's behavior,
so I have no objection.
-- Naoya Horiguchi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-21 10:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 6:28 [PATCH 0/7] HWPOISON for hugepage backed KVM guest Naoya Horiguchi
2011-01-21 6:28 ` [PATCH 1/7] hugetlb: check swap entry in follow_hugetlb_page() Naoya Horiguchi
2011-01-21 6:28 ` [PATCH 2/7] check hugepage swap entry in get_user_pages_fast() Naoya Horiguchi
2011-01-21 6:28 ` [PATCH 3/7] remove putback_lru_pages() in hugepage migration context Naoya Horiguchi
2011-01-21 6:40 ` Minchan Kim
2011-01-21 10:00 ` Naoya Horiguchi [this message]
2011-01-21 6:28 ` [PATCH 4/7] hugetlb, migration: add migration_hugepage_entry_wait() Naoya Horiguchi
2011-01-21 6:28 ` [PATCH 5/7] hugetlb: fix race condition between hugepage soft offline and page fault Naoya Horiguchi
2011-01-21 6:28 ` [PATCH 6/7] HWPOISON: pass order to set/clear_page_hwpoison_huge_page() Naoya Horiguchi
2011-01-21 6:29 ` [PATCH 7/7] HWPOISON, hugetlb: fix hard offline for hugepage backed KVM guest Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121100028.GA11102@spritzera.linux.bs1.fc.nec.co.jp \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=fernando@oss.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox