From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
Greg Thelen <gthelen@google.com>
Subject: Re: [PATCH 0/4] fix THP and memcg issues v2.
Date: Tue, 18 Jan 2011 11:31:48 +0900 [thread overview]
Message-ID: <20110118113148.77d5c0df.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20110118110604.e2528324.kamezawa.hiroyu@jp.fujitsu.com>
On Tue, 18 Jan 2011 11:06:04 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>
> Now, when THP is enabled, memcg's counter goes wrong. Moreover, rmdir()
> may not end. I fixed some races since v1.
>
>
> This series is a fix for obviouse counter breakage. When you test,
> CONFIG_TRANSPARENT_HUGEPAGE=y
> CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS=y
>
> is appreciated. Tests should be done is:
>
> # mount -t cgroup none /cgroup/memory -omemory
> # mkdir /cgroup/memory/A
> # mkdir /cgroup/memory/A/B
> # run some programs under B.
> # echo 0 > /cgroup/memory/A/B/memory.force_empty
>
> and check B's memory.stat shows RSS/CACHE/LRU are all 0.
> Moving tasks while running is another good test.
>
> I know there are another problem when memory cgroup hits limit and
> reclaim in busy. But I will fix it in another patch.
>
I found some mistake of patch handling in patch 2/4 and 3/4.
(a code for 2/4 was in 3/4...)
I'll send v3. I'm sorry.
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-01-18 2:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 2:06 KAMEZAWA Hiroyuki
2011-01-18 2:07 ` [PATCH 1/4] modify accounting function for supporting THP better KAMEZAWA Hiroyuki
2011-01-18 2:10 ` [PATCH 2/4] memcg: fixe USED bit handling at uncharge with THP KAMEZAWA Hiroyuki
2011-01-18 2:15 ` [PATCH 4/4] memcg: fix rmdir, force_empty " KAMEZAWA Hiroyuki
2011-01-18 2:14 ` [PATCH 3/4] memcg: fix LRU accounting " KAMEZAWA Hiroyuki
2011-01-18 2:31 ` KAMEZAWA Hiroyuki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118113148.77d5c0df.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox