From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id 88AB16B00E7 for ; Tue, 11 Jan 2011 01:33:59 -0500 (EST) Received: from m1.gw.fujitsu.co.jp (unknown [10.0.50.71]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 1C4313EE0BD for ; Tue, 11 Jan 2011 15:33:56 +0900 (JST) Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 0294445DE58 for ; Tue, 11 Jan 2011 15:33:56 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id E097E45DE56 for ; Tue, 11 Jan 2011 15:33:55 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id D3F021DB8048 for ; Tue, 11 Jan 2011 15:33:55 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.249.87.104]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id A05BE1DB8047 for ; Tue, 11 Jan 2011 15:33:55 +0900 (JST) Date: Tue, 11 Jan 2011 15:27:52 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH] memcg: remove charge variable in unmap_and_move Message-Id: <20110111152752.88a2d142.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1294725650-4732-1-git-send-email-minchan.kim@gmail.com> References: <1294725650-4732-1-git-send-email-minchan.kim@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , Balbir Singh , Daisuke Nishimura List-ID: On Tue, 11 Jan 2011 15:00:50 +0900 Minchan Kim wrote: > memcg charge/uncharge could be handled by mem_cgroup_[prepare/end] > migration itself so charge local variable in unmap_and_move lost the role > since we introduced 01b1ae63c2. > > In addition, the variable name is not good like below. > > int unmap_and_move() > { > charge = mem_cgroup_prepare_migration(xxx); > .. > BUG_ON(charge); <-- BUG if it is charged? > .. > uncharge: > if (!charge) <-- why do we have to uncharge !charge? > mem_group_end_migration(xxx); > .. > } > > So let's remove unnecessary and confusing variable. > > Suggested-by: Daisuke Nishimura > Signed-off-by: Minchan Kim > Cc: Balbir Singh > Cc: KAMEZAWA Hiroyuki Ack. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org