From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rik van Riel <riel@redhat.com>, linux-mm@kvack.org
Subject: Re: [patch] mm: skip rebalance of hopeless zones
Date: Wed, 5 Jan 2011 12:15:42 +0100 [thread overview]
Message-ID: <20110105111542.GC4654@cmpxchg.org> (raw)
In-Reply-To: <20101210162706.GQ2356@cmpxchg.org>
Andrew,
On Fri, Dec 10, 2010 at 05:27:06PM +0100, Johannes Weiner wrote:
> On Thu, Dec 09, 2010 at 01:17:23PM -0800, Andrew Morton wrote:
> > Does that mean we can expect a v2?
>
> Ok, while comparing Mel's patches with this change on IRC, I realized
> that the enterprise kernel the issue was reported against is lacking
> 'de3fab3 vmscan: kswapd: don't retry balance_pgdat() if all zones are
> unreclaimable'.
>
> The above change fixed the observed malfunction of course, but Occam's
> Razor suggests that de3fab3 will do so, too. I'll verify that, but I
> don't expect to send another version of this patch.
The problem is not reproducable on a kernel with de3fab3 applied. You
were right from the start, it was a bug in the all_unreclaimable code.
The hopeless zone patch fixed the bug as well. So I had a problem, a
working fix for it, and a broken mental image of the code that had me
convinced the all_unreclaimable logic was just not enough.
Maybe there is still a corner case where the all_unreclaimable logic
falls apart, but unless this happens in reality, I don't think there
is any reason to further pursue this.
> Sorry for the noise.
>
> Hannes
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-05 11:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 15:16 Johannes Weiner
2010-12-08 18:05 ` Rik van Riel
2010-12-08 22:19 ` Andrew Morton
2010-12-09 0:04 ` Johannes Weiner
2010-12-09 21:17 ` Andrew Morton
2010-12-10 16:27 ` Johannes Weiner
2011-01-05 11:15 ` Johannes Weiner [this message]
2011-01-04 23:56 ` Andrew Morton
2010-12-09 0:47 ` Rik van Riel
2010-12-09 14:34 ` Mel Gorman
2010-12-09 0:36 ` Simon Kirby
2010-12-09 0:49 ` Rik van Riel
2010-12-09 1:08 ` Simon Kirby
2010-12-09 14:42 ` Mel Gorman
2010-12-09 1:23 ` Andrew Morton
2010-12-09 1:55 ` Minchan Kim
2010-12-09 1:57 ` Minchan Kim
2010-12-09 2:01 ` Andrew Morton
2010-12-09 2:19 ` Minchan Kim
2010-12-09 5:18 ` Minchan Kim
2010-12-09 2:05 ` Simon Kirby
2010-12-09 8:55 ` Pekka Enberg
2010-12-09 14:46 ` Mel Gorman
2010-12-09 14:44 ` Mel Gorman
2010-12-09 18:03 ` Andrew Morton
2010-12-09 18:48 ` Ying Han
2010-12-10 11:34 ` Mel Gorman
2010-12-09 18:39 ` Ying Han
2010-12-10 11:37 ` Mel Gorman
2010-12-10 19:46 ` Ying Han
2010-12-09 1:29 ` Minchan Kim
2010-12-09 18:51 ` Ying Han
2010-12-10 7:25 ` KOSAKI Motohiro
2010-12-10 7:37 ` KOSAKI Motohiro
2010-12-10 10:54 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105111542.GC4654@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox