From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 14FCC6B00AA for ; Sun, 19 Dec 2010 21:21:56 -0500 (EST) Received: from m3.gw.fujitsu.co.jp ([10.0.50.73]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id oBK2Lsv7027406 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Mon, 20 Dec 2010 11:21:54 +0900 Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 1767B45DE5F for ; Mon, 20 Dec 2010 11:21:54 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id F1E7245DE5C for ; Mon, 20 Dec 2010 11:21:53 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id DE2C4E08004 for ; Mon, 20 Dec 2010 11:21:53 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id A60A7E18002 for ; Mon, 20 Dec 2010 11:21:53 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [RFC 5/5] truncate: Remove unnecessary page release In-Reply-To: <02ab98b3a1450f7a1c31edc48ccc57e887cee900.1292604746.git.minchan.kim@gmail.com> References: <02ab98b3a1450f7a1c31edc48ccc57e887cee900.1292604746.git.minchan.kim@gmail.com> Message-Id: <20101220112227.E566.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Mon, 20 Dec 2010 11:21:52 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: kosaki.motohiro@jp.fujitsu.com, Andrew Morton , linux-mm , LKML , Nick Piggin , Al Viro List-ID: > This patch series changes remove_from_page_cache's page ref counting > rule. page cache ref count is decreased in remove_from_page_cache. > So we don't need call again in caller context. > > Cc: Nick Piggin > Cc: Al Viro > Cc: linux-mm@kvack.org > Signed-off-by: Minchan Kim > --- > mm/truncate.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/mm/truncate.c b/mm/truncate.c > index 9ee5673..8decb93 100644 > --- a/mm/truncate.c > +++ b/mm/truncate.c > @@ -114,7 +114,6 @@ truncate_complete_page(struct address_space *mapping, struct page *page) > * calls cleancache_put_page (and note page->mapping is now NULL) > */ > cleancache_flush_page(mapping, page); > - page_cache_release(page); /* pagecache ref */ > return 0; Do we _always_ have stable page reference here? IOW, I can assume cleancache_flush_page() doesn't cause NULL deref? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org