From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Hugh Dickins <hughd@google.com>
Subject: Re: [RFC 1/5] drop page reference on remove_from_page_cache
Date: Mon, 20 Dec 2010 10:53:22 +0900 [thread overview]
Message-ID: <20101220105322.3b0dba88.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <4bd059fc4f45fba7ed29a9f4325deb4f437d39f3.1292604745.git.minchan.kim@gmail.com>
On Sat, 18 Dec 2010 02:13:36 +0900
Minchan Kim <minchan.kim@gmail.com> wrote:
> Now we add page reference on add_to_page_cache but doesn't drop it
> in remove_from_page_cache. Such asymmetric makes confusing about
> page reference so that caller should notice it and comment why they
> release page reference. It's not good API.
>
> Long time ago, Hugh tried it[1] but gave up of reason which
> reiser4's drop_page had to unlock the page between removing it from
> page cache and doing the page_cache_release. But now the situation is
> changed. I think at least things in current mainline doesn't have any
> obstacles. The problem is fs or somethings out of mainline.
> If it has done such thing like reiser4, this patch could be a problem.
>
> Do anyone know the such things? Do we care about things out of mainline?
>
> Note :
> The comment of remove_from_page_cache make by copy & paste & s/swap/page/
> from delete_from_swap_cache.
>
> [1] http://lkml.org/lkml/2004/10/24/140
>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: linux-mm@kvack.org
> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
I like this.
Reviewd-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-20 1:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 17:13 [RFC 0/5] Change page reference hanlding semantic of page cache Minchan Kim
2010-12-17 17:13 ` [RFC 1/5] drop page reference on remove_from_page_cache Minchan Kim
2010-12-20 1:53 ` KAMEZAWA Hiroyuki [this message]
2010-12-17 17:13 ` [RFC 2/5] fuse: Remove unnecessary page release Minchan Kim
2010-12-20 1:54 ` KAMEZAWA Hiroyuki
2010-12-17 17:13 ` [RFC 3/5] tlbfs: " Minchan Kim
2010-12-20 1:54 ` KAMEZAWA Hiroyuki
2011-01-06 9:56 ` Mel Gorman
2011-01-10 15:39 ` Minchan Kim
2010-12-17 17:13 ` [RFC 4/5] swap: " Minchan Kim
2010-12-20 1:55 ` KAMEZAWA Hiroyuki
2010-12-17 17:13 ` [RFC 5/5] truncate: " Minchan Kim
2010-12-20 1:55 ` KAMEZAWA Hiroyuki
2010-12-20 2:21 ` KOSAKI Motohiro
2010-12-20 2:27 ` KAMEZAWA Hiroyuki
2010-12-20 2:58 ` Minchan Kim
2010-12-20 4:35 ` KAMEZAWA Hiroyuki
2010-12-20 8:09 ` Minchan Kim
2010-12-20 8:54 ` KAMEZAWA Hiroyuki
2010-12-20 2:27 ` Minchan Kim
2010-12-20 2:32 ` KOSAKI Motohiro
2010-12-20 2:49 ` Minchan Kim
2010-12-20 3:03 ` KOSAKI Motohiro
2010-12-20 3:31 ` Minchan Kim
2010-12-20 10:33 ` [RFC 0/5] Change page reference hanlding semantic of page cache Christoph Hellwig
2010-12-20 23:36 ` Minchan Kim
2010-12-21 5:07 ` Hugh Dickins
2010-12-21 7:32 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220105322.3b0dba88.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox