From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: add replace_page_cache_page() function
Date: Mon, 20 Dec 2010 08:54:13 +0900 [thread overview]
Message-ID: <20101220085413.b83d1093.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <E1PTcau-0001aw-60@pomaz-ex.szeredi.hu>
On Fri, 17 Dec 2010 16:51:44 +0100
Miklos Szeredi <miklos@szeredi.hu> wrote:
> On Fri, 17 Dec 2010, KAMEZAWA Hiroyuki wrote:
> > No. memory cgroup expects all pages should be found on LRU. But, IIUC,
> > pages on this radix-tree will not be on LRU. So, memory cgroup can't find
> > it at destroying cgroup and can't reduce "usage" of resource to be 0.
> > This makes rmdir() returns -EBUSY.
>
> Oh, right. Yes, the page will be on the LRU (it needs to be,
> otherwise the VM coulnd't reclaim it). After the
> add_to_page_cache_locked is this:
>
> if (!(buf->flags & PIPE_BUF_FLAG_LRU))
> lru_cache_add_file(newpage);
>
> It will add the page to the LRU, unless it's already on it.
>
Thank you for clarification.
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-20 0:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 15:49 Miklos Szeredi
2010-12-15 16:49 ` Rik van Riel
2010-12-15 23:22 ` Minchan Kim
2010-12-16 11:59 ` Miklos Szeredi
2010-12-16 22:04 ` Minchan Kim
2010-12-17 1:21 ` Hugh Dickins
2010-12-17 1:40 ` Minchan Kim
2010-12-17 2:10 ` Hugh Dickins
2010-12-17 4:37 ` Minchan Kim
2010-12-17 15:53 ` Miklos Szeredi
2010-12-16 1:07 ` KAMEZAWA Hiroyuki
2010-12-16 12:05 ` Miklos Szeredi
2010-12-17 0:01 ` KAMEZAWA Hiroyuki
2010-12-17 15:51 ` Miklos Szeredi
2010-12-19 23:54 ` KAMEZAWA Hiroyuki [this message]
2011-01-07 18:22 Miklos Szeredi
2011-01-11 2:29 ` KAMEZAWA Hiroyuki
2011-01-11 3:53 ` Daisuke Nishimura
2011-01-11 9:38 ` Miklos Szeredi
2011-01-11 5:41 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220085413.b83d1093.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox