From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id EE2B66B0096 for ; Mon, 13 Dec 2010 14:38:28 -0500 (EST) Received: by pzk3 with SMTP id 3so616834pzk.2 for ; Mon, 13 Dec 2010 11:38:26 -0800 (PST) Date: Mon, 13 Dec 2010 12:38:18 -0700 From: Eric B Munson Subject: Re: [PATCH 3/6] mm: kswapd: Use the order that kswapd was reclaiming at for sleeping_prematurely() Message-ID: <20101213193818.GE3401@mgebm.net> References: <1291995985-5913-1-git-send-email-mel@csn.ul.ie> <1291995985-5913-4-git-send-email-mel@csn.ul.ie> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Ns7jmDPpOpCD+GE/" Content-Disposition: inline In-Reply-To: <1291995985-5913-4-git-send-email-mel@csn.ul.ie> Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: Andrew Morton , Simon Kirby , KOSAKI Motohiro , Shaohua Li , Dave Hansen , Johannes Weiner , linux-mm , linux-kernel List-ID: --Ns7jmDPpOpCD+GE/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, 10 Dec 2010, Mel Gorman wrote: > Before kswapd goes to sleep, it uses sleeping_prematurely() to check if > there was a race pushing a zone below its watermark. If the race happened, > it stays awake. However, balance_pgdat() can decide to reclaim at order-0 > if it decides that high-order reclaim is not working as expected. This > information is not passed back to sleeping_prematurely(). The impact is > that kswapd remains awake reclaiming pages long after it should have gone > to sleep. This patch passes the adjusted order to sleeping_prematurely and > uses the same logic as balance_pgdat to decide if it's ok to go to sleep. >=20 > Signed-off-by: Mel Gorman > Reviewed-by: Minchan Kim > Reviewed-by: KAMEZAWA Hiroyuki Reviewed-by: Eric B Munson --Ns7jmDPpOpCD+GE/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEcBAEBAgAGBQJNBnYqAAoJEH65iIruGRnNDvgIAKt6gxTnJrGvkVEjA9EtUBKR m+hOcsCQlzxCz4KSCgxOutFx9NsqO7eFmhCeSFeul77DQlfi/a8lD2jWYtDynmZn aR39vSQwYhQFb1sFdWTaerNpkbcmqwIYGFTG7/0F9EguDrnGSiP2tKx+ujHlfUC9 b3mKY57WwtG8tRqheIXOs+qplzeVwe5LEvHslArfX4g61P3JT1uXPabeuZiFhTyz V/lAATt+Qc+WVHhh6HfFG9sP8FnL36TAsnU3NStyIP3wM0b0kNV0O+p3oyKpTrWU uLOHK0UDGKrFXr1iTYCgwDWsf5NQ3nP1485EAi6RdETovfvOFyLFzWI1M/lnPik= =w/zD -----END PGP SIGNATURE----- --Ns7jmDPpOpCD+GE/-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org