From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id A0AE46B008C for ; Thu, 9 Dec 2010 10:59:39 -0500 (EST) Received: by gwb17 with SMTP id 17so1959051gwb.30 for ; Thu, 09 Dec 2010 07:59:34 -0800 (PST) Date: Fri, 10 Dec 2010 00:59:25 +0900 From: Minchan Kim Subject: Re: [PATCH 4/6] mm: kswapd: Reset kswapd_max_order and classzone_idx after reading Message-ID: <20101209155925.GD1740@barrios-desktop> References: <1291893500-12342-1-git-send-email-mel@csn.ul.ie> <1291893500-12342-5-git-send-email-mel@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1291893500-12342-5-git-send-email-mel@csn.ul.ie> Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: Simon Kirby , KOSAKI Motohiro , Shaohua Li , Dave Hansen , Johannes Weiner , Andrew Morton , linux-mm , linux-kernel List-ID: On Thu, Dec 09, 2010 at 11:18:18AM +0000, Mel Gorman wrote: > When kswapd wakes up, it reads its order and classzone from pgdat and > calls balance_pgdat. While its awake, it potentially reclaimes at a high > order and a low classzone index. This might have been a once-off that > was not required by subsequent callers. However, because the pgdat > values were not reset, they remain artifically high while > balance_pgdat() is running and potentially kswapd enters a second > unnecessary reclaim cycle. Reset the pgdat order and classzone index > after reading. > > Signed-off-by: Mel Gorman Reviewed-by: Minchan Kim -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org