From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id B20566B0087 for ; Wed, 8 Dec 2010 02:22:34 -0500 (EST) Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id oB87MWFg007038 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Wed, 8 Dec 2010 16:22:32 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 075B445DE86 for ; Wed, 8 Dec 2010 16:22:32 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id E1C9E45DD74 for ; Wed, 8 Dec 2010 16:22:31 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id D33F31DB8038 for ; Wed, 8 Dec 2010 16:22:31 +0900 (JST) Received: from m108.s.css.fujitsu.com (m108.s.css.fujitsu.com [10.249.87.108]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 9E7FE1DB803E for ; Wed, 8 Dec 2010 16:22:31 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH 1/4] Add kswapd descriptor. In-Reply-To: <20101207123308.GD5422@csn.ul.ie> References: <1291099785-5433-2-git-send-email-yinghan@google.com> <20101207123308.GD5422@csn.ul.ie> Message-Id: <20101208162257.1748.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Wed, 8 Dec 2010 16:22:30 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: kosaki.motohiro@jp.fujitsu.com, Ying Han , Balbir Singh , Daisuke Nishimura , KAMEZAWA Hiroyuki , Andrew Morton , Johannes Weiner , Christoph Lameter , Wu Fengguang , Andi Kleen , Hugh Dickins , Rik van Riel , Tejun Heo , linux-mm@kvack.org List-ID: > > +struct kswapd { > > + struct task_struct *kswapd_task; > > + wait_queue_head_t kswapd_wait; > > + struct mem_cgroup *kswapd_mem; > > + pg_data_t *kswapd_pgdat; > > +}; > > + > > +#define MAX_KSWAPDS MAX_NUMNODES > > +extern struct kswapd kswapds[MAX_KSWAPDS]; > > This is potentially very large for a static structure. Can they not be > dynamically allocated and kept on a list? Yes, there will be a list walk > involved if yonu need a particular structure but that looks like it's a > rare operation at this point. Why can't we use normal workqueue mechanism? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org