From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: balbir@linux.vnet.ibm.com
Cc: linux-mm@kvack.org, Christoph Lameter <cl@linux.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH 2/3] Refactor zone_reclaim
Date: Wed, 1 Dec 2010 17:59:11 +0900 [thread overview]
Message-ID: <20101201175911.b761ce81.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20101201052218.GK2746@balbir.in.ibm.com>
On Wed, 1 Dec 2010 10:52:18 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> * Balbir Singh <balbir@linux.vnet.ibm.com> [2010-12-01 10:16:34]:
>
> > * KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2010-12-01 10:23:29]:
> >
> > > On Tue, 30 Nov 2010 15:45:55 +0530
> > > Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> > >
> > > > Refactor zone_reclaim, move reusable functionality outside
> > > > of zone_reclaim. Make zone_reclaim_unmapped_pages modular
> > > >
> > > > Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
> > >
> > > Why is this min_mapped_pages based on zone (IOW, per-zone) ?
> > >
> >
> > Kamezawa-San, this has been the design before the refactoring (it is
> > based on zone_reclaim_mode and reclaim based on top of that). I am
> > reusing bits of existing technology. The advantage of it being
> > per-zone is that it integrates well with kswapd.
> >
>
Sorry, what I wanted to here was:
Why min_mapped_pages per zone ?
Why you don't add "limit_for_unmapped_page_cache_size" for the whole system ?
I guess what you really want is "limit_for_unmapped_page_cache_size".
Then, you have to use this kind of mysterious code.
==
(zone_unmapped_file_pages(zone) >
+ UNMAPPED_PAGE_RATIO * zone->min_unmapped_pages))
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-01 9:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 10:14 [PATCH 0/3] Series short description Balbir Singh
2010-11-30 10:15 ` [PATCH 1/3] Move zone_reclaim() outside of CONFIG_NUMA Balbir Singh
2010-11-30 19:18 ` Christoph Lameter
2010-11-30 22:23 ` Andrew Morton
[not found] ` <20101201043408.GE2746@balbir.in.ibm.com>
2010-12-01 5:21 ` Balbir Singh
2010-11-30 10:15 ` [PATCH 2/3] Refactor zone_reclaim Balbir Singh
2010-11-30 19:19 ` Christoph Lameter
2010-12-01 1:23 ` KAMEZAWA Hiroyuki
[not found] ` <20101201044634.GF2746@balbir.in.ibm.com>
2010-12-01 5:22 ` Balbir Singh
2010-12-01 8:59 ` KAMEZAWA Hiroyuki [this message]
2010-12-01 7:54 ` Minchan Kim
2010-11-30 10:16 ` [PATCH 3/3] Provide control over unmapped pages Balbir Singh
2010-11-30 19:21 ` Christoph Lameter
2010-11-30 22:25 ` Andrew Morton
[not found] ` <20101201045421.GG2746@balbir.in.ibm.com>
2010-12-01 5:22 ` Balbir Singh
2010-12-01 8:18 ` Minchan Kim
2010-12-01 15:01 ` Christoph Lameter
2010-12-02 1:22 ` KOSAKI Motohiro
2010-12-02 2:50 ` KAMEZAWA Hiroyuki
2010-12-02 7:01 ` Balbir Singh
2010-12-01 0:14 ` KOSAKI Motohiro
[not found] ` <20101201051632.GH2746@balbir.in.ibm.com>
2010-12-01 5:22 ` Balbir Singh
2010-12-01 1:32 ` KAMEZAWA Hiroyuki
[not found] ` <20101201051816.GI2746@balbir.in.ibm.com>
2010-12-01 5:22 ` Balbir Singh
2010-12-01 5:35 ` KAMEZAWA Hiroyuki
2010-12-01 6:40 ` Balbir Singh
2010-12-01 7:24 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201175911.b761ce81.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=cl@linux.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox