linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: linux-mm@kvack.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	balbir@linux.vnet.ibm.com
Subject: Re: [RFC PATCH] Make swap accounting default behavior configurable v3
Date: Mon, 15 Nov 2010 09:35:40 +0100	[thread overview]
Message-ID: <20101115083540.GA20156@tiehlicka.suse.cz> (raw)
In-Reply-To: <20101115101335.8880fd87.nishimura@mxp.nes.nec.co.jp>

On Mon 15-11-10 10:13:35, Daisuke Nishimura wrote:
> On Fri, 12 Nov 2010 09:31:03 +0100
[...]
> > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> > index ed45e98..7077148 100644
> > --- a/Documentation/kernel-parameters.txt
> > +++ b/Documentation/kernel-parameters.txt
> > @@ -1752,6 +1752,8 @@ and is between 256 and 4096 characters. It is defined in the file
> >  
> >  	noswapaccount	[KNL] Disable accounting of swap in memory resource
> >  			controller. (See Documentation/cgroups/memory.txt)
> > +	swapaccount	[KNL] Enable accounting of swap in memory resource
> > +			controller. (See Documentation/cgroups/memory.txt)
> >  
> >  	nosync		[HW,M68K] Disables sync negotiation for all devices.
> >  
> (I've add Andrew and Balbir to CC-list.)
> It seems that almost all parameters are listed in alphabetic order in the document,
> so I think it would be better to obey the rule.

You are right. The header of the file says:

" The following is a consolidated list of the kernel parameters as
implemented (mostly) by the __setup() macro and sorted into English
Dictionary order (defined as ignoring all punctuation and sorting digits
before letters in a case insensitive manner), and with descriptions
where known."

Updated patch follows bellow.

> 
> Thanks,
> Daisuke Nishimura.

Changes since v2:
* put the new parameter description to the proper (alphabetically sorted)
  place in Documentation/kernel-parameters.txt

Changes since v1:
* do not remove noswapaccount parameter and add swapaccount parameter instead
* Documentation/kernel-parameters.txt updated
---

  parent reply	other threads:[~2010-11-15  8:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-10 12:51 [RFC PATCH] Make swap accounting default behavior configurable Michal Hocko
2010-11-11  0:46 ` Daisuke Nishimura
2010-11-11  9:31   ` Michal Hocko
2010-11-12  0:41     ` Daisuke Nishimura
2010-11-12  8:31       ` [RFC PATCH] Make swap accounting default behavior configurable v2 Michal Hocko
2010-11-15  1:13         ` Daisuke Nishimura
2010-11-15  2:03           ` Balbir Singh
2010-11-15  2:31             ` Daisuke Nishimura
2010-11-15  8:35           ` Michal Hocko [this message]
2010-11-16  4:48             ` [RFC PATCH] Make swap accounting default behavior configurable v3 Daisuke Nishimura
2010-11-16  8:15               ` Michal Hocko
2010-11-16 10:03                 ` Daisuke Nishimura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101115083540.GA20156@tiehlicka.suse.cz \
    --to=mhocko@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nishimura@mxp.nes.nec.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox