From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 06C6E6B00BD for ; Mon, 8 Nov 2010 22:18:53 -0500 (EST) Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id oA93IpZ6027628 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Tue, 9 Nov 2010 12:18:51 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 2E8A745DE4E for ; Tue, 9 Nov 2010 12:18:51 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 09EE545DE51 for ; Tue, 9 Nov 2010 12:18:51 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id DA1A21DB8055 for ; Tue, 9 Nov 2010 12:18:50 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 708AC1DB8054 for ; Tue, 9 Nov 2010 12:18:50 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH 01 of 66] disable lumpy when compaction is enabled In-Reply-To: References: Message-Id: <20101109121318.BC51.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Tue, 9 Nov 2010 12:18:49 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Andrea Arcangeli Cc: kosaki.motohiro@jp.fujitsu.com, linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Hugh Dickins , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov List-ID: > From: Andrea Arcangeli > > Compaction is more reliable than lumpy, and lumpy makes the system unusable > when it runs. > > Signed-off-by: Andrea Arcangeli > --- > > diff --git a/mm/vmscan.c b/mm/vmscan.c > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -274,6 +274,7 @@ unsigned long shrink_slab(unsigned long > static void set_lumpy_reclaim_mode(int priority, struct scan_control *sc, > bool sync) > { > +#ifndef CONFIG_COMPACTION > enum lumpy_mode mode = sync ? LUMPY_MODE_SYNC : LUMPY_MODE_ASYNC; > > /* > @@ -294,11 +295,14 @@ static void set_lumpy_reclaim_mode(int p > sc->lumpy_reclaim_mode = mode; > else > sc->lumpy_reclaim_mode = LUMPY_MODE_NONE; > +#endif > } I'm talking very personal thing now. I'm usually testing both feature. Then, runtime switching makes my happy :-) However I don't know what are you and Mel talking and agree about this. So, If many developer prefer this approach, I don't oppose anymore. But, I bet almost all distro choose CONFIG_COMPACTION=y. then, lumpy code will become nearly dead code. So, I like just kill than dead code. however it is also only my preference. ;) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org