* [PATCH] memcg: correct memcg_hierarchical_free_pages() return type
@ 2010-11-09 1:17 Greg Thelen
2010-11-09 1:49 ` Johannes Weiner
0 siblings, 1 reply; 2+ messages in thread
From: Greg Thelen @ 2010-11-09 1:17 UTC (permalink / raw)
To: Andrew Morton
Cc: Balbir Singh, KAMEZAWA Hiroyuki, Daisuke Nishimura,
Johannes Weiner, Wu Fengguang, linux-mm, linux-kernel,
Greg Thelen
memcg_hierarchical_free_pages() returns a page count and thus
should return unsigned long to be consistent with the rest of
mm code.
Signed-off-by: Greg Thelen <gthelen@google.com>
---
mm/memcontrol.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index b287afd..35870f9 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1340,7 +1340,7 @@ static long mem_cgroup_local_page_stat(struct mem_cgroup *mem,
* use_hierarchy is set, then this involves parent mem cgroups to find the
* cgroup with the smallest free space.
*/
-static unsigned long long
+static unsigned long
memcg_hierarchical_free_pages(struct mem_cgroup *mem)
{
unsigned long free, min_free;
--
1.7.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] memcg: correct memcg_hierarchical_free_pages() return type
2010-11-09 1:17 [PATCH] memcg: correct memcg_hierarchical_free_pages() return type Greg Thelen
@ 2010-11-09 1:49 ` Johannes Weiner
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Weiner @ 2010-11-09 1:49 UTC (permalink / raw)
To: Greg Thelen
Cc: Andrew Morton, Balbir Singh, KAMEZAWA Hiroyuki,
Daisuke Nishimura, Wu Fengguang, linux-mm, linux-kernel
On Mon, Nov 08, 2010 at 05:17:10PM -0800, Greg Thelen wrote:
> memcg_hierarchical_free_pages() returns a page count and thus
> should return unsigned long to be consistent with the rest of
> mm code.
>
> Signed-off-by: Greg Thelen <gthelen@google.com>
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-09 1:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-09 1:17 [PATCH] memcg: correct memcg_hierarchical_free_pages() return type Greg Thelen
2010-11-09 1:49 ` Johannes Weiner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox