From: hannes@cmpxchg.org
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dave Young <hidave.darkstar@gmail.com>,
Greg Thelen <gthelen@google.com>,
Andrea Righi <arighi@develer.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] memcg: use do_div to divide s64 in 32 bit machine.
Date: Sat, 6 Nov 2010 02:03:57 +0100 [thread overview]
Message-ID: <20101106010357.GD23393@cmpxchg.org> (raw)
In-Reply-To: <1288973333-7891-1-git-send-email-minchan.kim@gmail.com>
On Sat, Nov 06, 2010 at 01:08:53AM +0900, Minchan Kim wrote:
> Use do_div to divide s64 value. Otherwise, build would be failed
> like Dave Young reported.
I thought about that too, but then I asked myself why you would want
to represent a number of pages as signed 64bit type, even on 32 bit?
Isn't the much better fix to get the types right instead?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-06 1:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 16:08 Minchan Kim
2010-11-05 16:34 ` Greg Thelen
2010-11-06 1:03 ` hannes [this message]
2010-11-06 17:19 ` Greg Thelen
2010-11-06 17:31 ` Minchan Kim
2010-11-07 22:14 ` [patch 0/4] memcg: variable type fixes Johannes Weiner
2010-11-07 22:14 ` [patch 1/4] memcg: use native word to represent dirtyable pages Johannes Weiner
2010-11-07 22:56 ` Minchan Kim
2010-11-08 22:25 ` Greg Thelen
2010-11-08 22:38 ` Johannes Weiner
2010-11-08 22:43 ` Greg Thelen
2010-11-16 3:37 ` KAMEZAWA Hiroyuki
2010-11-07 22:14 ` [patch 2/4] memcg: catch negative per-cpu sums in dirty info Johannes Weiner
2010-11-07 23:26 ` Minchan Kim
2010-11-08 22:28 ` Greg Thelen
2010-11-16 3:39 ` KAMEZAWA Hiroyuki
2010-11-07 22:14 ` [patch 3/4] memcg: break out event counters from other stats Johannes Weiner
2010-11-07 23:52 ` Minchan Kim
2010-11-08 23:20 ` Greg Thelen
2010-11-16 3:41 ` KAMEZAWA Hiroyuki
2010-11-07 22:14 ` [patch 4/4] memcg: use native word page statistics counters Johannes Weiner
2010-11-08 0:01 ` Minchan Kim
2010-11-08 9:08 ` Johannes Weiner
2010-11-08 22:51 ` Greg Thelen
2010-11-08 0:07 ` Minchan Kim
2010-11-08 9:37 ` memcg writeout throttling, was: " Johannes Weiner
2010-11-08 15:45 ` Wu Fengguang
2010-11-08 19:00 ` Greg Thelen
2010-11-08 23:27 ` Greg Thelen
2010-11-08 23:45 ` Johannes Weiner
2010-11-16 3:44 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101106010357.GD23393@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=arighi@develer.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=gthelen@google.com \
--cc=hidave.darkstar@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox