From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id 8C3116B0168 for ; Tue, 2 Nov 2010 08:24:21 -0400 (EDT) Date: Tue, 2 Nov 2010 08:24:13 -0400 From: Johannes Weiner Subject: Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code. Message-ID: <20101102122413.GJ840@cmpxchg.org> References: <20101101200122.GH840@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Jesper Juhl Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Balbir Singh , Pavel Emelianov , Minchan Kim , Paul Menage , Li Zefan , containers@lists.linux-foundation.org List-ID: On Mon, Nov 01, 2010 at 08:59:13PM +0100, Jesper Juhl wrote: > On Mon, 1 Nov 2010, Johannes Weiner wrote: > > > On Mon, Nov 01, 2010 at 08:40:56PM +0100, Jesper Juhl wrote: > > > In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then > > > followed by memset() to zero the memory. This can be more efficiently > > > achieved by using kzalloc() and vzalloc(). > > > > > > Signed-off-by: Jesper Juhl > > > > Looks good to me, but there is also the memset after kmalloc in > > alloc_mem_cgroup_per_zone_info(). Can you switch that over as well > > in this patch? You can pass __GFP_ZERO to kmalloc_node() for zeroing. > > Sure thing. > > Signed-off-by: Jesper Juhl Thanks. Reviewed-by: Johannes Weiner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org