From: Johannes Weiner <hannes@cmpxchg.org>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Pavel Emelianov <xemul@openvz.org>,
Minchan Kim <minchan.kim@gmail.com>,
Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
containers@lists.linux-foundation.org
Subject: Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.
Date: Tue, 2 Nov 2010 08:24:13 -0400 [thread overview]
Message-ID: <20101102122413.GJ840@cmpxchg.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1011012056250.12889@swampdragon.chaosbits.net>
On Mon, Nov 01, 2010 at 08:59:13PM +0100, Jesper Juhl wrote:
> On Mon, 1 Nov 2010, Johannes Weiner wrote:
>
> > On Mon, Nov 01, 2010 at 08:40:56PM +0100, Jesper Juhl wrote:
> > > In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then
> > > followed by memset() to zero the memory. This can be more efficiently
> > > achieved by using kzalloc() and vzalloc().
> > >
> > > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> >
> > Looks good to me, but there is also the memset after kmalloc in
> > alloc_mem_cgroup_per_zone_info(). Can you switch that over as well
> > in this patch? You can pass __GFP_ZERO to kmalloc_node() for zeroing.
>
> Sure thing.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Thanks.
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-02 12:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 19:40 Jesper Juhl
2010-11-01 19:58 ` Hiroyuki Kamezawa
2010-11-01 20:01 ` Johannes Weiner
2010-11-01 19:59 ` Jesper Juhl
2010-11-01 23:21 ` Minchan Kim
2010-11-02 12:24 ` Johannes Weiner [this message]
2010-11-03 14:15 ` Wu Fengguang
2010-11-02 5:07 ` Balbir Singh
-- strict thread matches above, loose matches on Subject: below --
2010-11-01 19:35 Jesper Juhl
2010-11-01 23:11 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101102122413.GJ840@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=minchan.kim@gmail.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox