From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
Bob Liu <lliubbo@gmail.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"mel@csn.ul.ie" <mel@csn.ul.ie>,
"kosaki.motohiro@jp.fujitsu.com" <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH] do_migrate_range: avoid failure as much as possible
Date: Mon, 25 Oct 2010 12:09:01 +0900 [thread overview]
Message-ID: <20101025120901.88fdbd17.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20101025120550.45745c3d.kamezawa.hiroyu@jp.fujitsu.com>
On Mon, 25 Oct 2010 12:05:50 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> This changes behavior.
>
> This "ret" can be > 0 because migrate_page()'s return code is
> "Return: Number of pages not migrated or error code."
>
> Then,
> ret < 0 ===> maybe ebusy
> ret > 0 ===> some pages are not migrated. maybe PG_writeback or some
> ret == 0 ===> ok, all condition green. try next chunk soon.
>
> Then, I added "yield()" and --retrym_max for !ret cases.
^^^^^^^^
wrong.
The code here does
ret == 0 ==> ok, all condition green, try next chunk.
ret > 0 ==> all pages are isolated but some pages cannot be migrated. maybe under I/O
do yield.
ret < 0 ==> some pages may not be able to be isolated. reduce retrycount and yield()
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-25 3:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 2:47 Bob Liu
2010-10-25 2:40 ` KAMEZAWA Hiroyuki
2010-10-25 2:57 ` Wu Fengguang
2010-10-25 3:05 ` KAMEZAWA Hiroyuki
2010-10-25 3:09 ` KAMEZAWA Hiroyuki [this message]
2010-10-25 3:48 ` Wu Fengguang
2010-10-25 3:48 ` KAMEZAWA Hiroyuki
2010-10-25 4:06 ` Wu Fengguang
2010-10-25 4:34 ` KAMEZAWA Hiroyuki
2010-10-25 4:55 ` Wu Fengguang
2010-10-25 4:00 ` Bob Liu
2010-10-25 3:28 ` Wu Fengguang
2010-10-25 3:50 ` KAMEZAWA Hiroyuki
2010-10-25 3:06 ` Wu Fengguang
2010-10-25 3:16 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025120901.88fdbd17.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox