From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Bob Liu <lliubbo@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
fengguang.wu@intel.com, mel@csn.ul.ie,
kosaki.motohiro@jp.fujitsu.com
Subject: Re: [PATCH 2/3] do_migrate_range: exit loop if not_managed is true.
Date: Fri, 22 Oct 2010 17:43:43 +0900 [thread overview]
Message-ID: <20101022174343.cf474ab3.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <AANLkTik9p3U-oUPC=KrUbd5iBWgEGJYKx8bHcWNkUCuE@mail.gmail.com>
On Fri, 22 Oct 2010 16:41:13 +0800
Bob Liu <lliubbo@gmail.com> wrote:
> On Fri, Oct 22, 2010 at 11:16 AM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > On Thu, 21 Oct 2010 21:28:20 +0800
> > Bob Liu <lliubbo@gmail.com> wrote:
> >
> >> If not_managed is true all pages will be putback to lru, so
> >> break the loop earlier to skip other pages isolate.
> >>
> >> Signed-off-by: Bob Liu <lliubbo@gmail.com>
> >
> > please don't skip dump_page().
> >
>
> Hi, Kame
>
> I put the check after dump_page() in order to we can still see the
> dump message if the loop is broken earlier.
>
> Thanks
>
Ah, sorry. I misunderstood.
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-22 8:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 13:28 [PATCH 1/3] page_isolation: codeclean fix comment and rm unneeded val init Bob Liu
2010-10-21 13:28 ` [PATCH 2/3] do_migrate_range: exit loop if not_managed is true Bob Liu
2010-10-21 13:28 ` [PATCH 3/3] do_migrate_range: reduce list_empty() check Bob Liu
2010-10-22 3:17 ` KAMEZAWA Hiroyuki
2010-10-25 6:02 ` Wu Fengguang
2010-10-25 21:36 ` Andrew Morton
2010-10-21 14:25 ` [PATCH 2/3] do_migrate_range: exit loop if not_managed is true Wu Fengguang
2010-10-22 2:48 ` Bob Liu
2010-10-22 3:22 ` Wu Fengguang
2010-10-22 8:41 ` Bob Liu
2010-10-22 10:23 ` Wu Fengguang
2010-10-22 3:16 ` KAMEZAWA Hiroyuki
2010-10-22 8:41 ` Bob Liu
2010-10-22 8:43 ` KAMEZAWA Hiroyuki [this message]
2010-10-25 5:51 ` Wu Fengguang
2010-10-21 14:01 ` [PATCH 1/3] page_isolation: codeclean fix comment and rm unneeded val init Wu Fengguang
2010-10-22 2:34 ` Bob Liu
2010-10-22 3:13 ` Wu Fengguang
2010-10-22 3:12 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022174343.cf474ab3.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox