From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 659A06B0089 for ; Wed, 20 Oct 2010 02:16:07 -0400 (EDT) Date: Wed, 20 Oct 2010 15:09:57 +0900 From: Daisuke Nishimura Subject: Re: [PATCH v2][memcg+dirtylimit] Fix overwriting global vm dirty limit setting by memcg (Re: [PATCH v3 00/11] memcg: per cgroup dirty page accounting Message-Id: <20101020150957.547c76d2.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20101020140255.5b8afb63.kamezawa.hiroyu@jp.fujitsu.com> References: <1287448784-25684-1-git-send-email-gthelen@google.com> <20101020122144.47f2b60b.kamezawa.hiroyu@jp.fujitsu.com> <20101020140255.5b8afb63.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Greg Thelen , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, containers@lists.osdl.org, Andrea Righi , Balbir Singh , Minchan Kim , Ciju Rajan K , David Rientjes , Daisuke Nishimura List-ID: On Wed, 20 Oct 2010 14:02:55 +0900 KAMEZAWA Hiroyuki wrote: > Fixed one here. > == > From: KAMEZAWA Hiroyuki > > Now, at calculating dirty limit, vm_dirty_param() is called. > This function returns dirty-limit related parameters considering > memory cgroup settings. > > Now, assume that vm_dirty_bytes=100M (global dirty limit) and > memory cgroup has 1G of pages and 40 dirty_ratio, dirtyable memory is > 500MB. > > In this case, global_dirty_limits will consider dirty_limt as > 500 *0.4 = 200MB. This is bad...memory cgroup is not back door. > > This patch limits the return value of vm_dirty_param() considring > global settings. > > Changelog: > - fixed an argument "mem" int to u64 > - fixed to use global available memory to cap memcg's value. > > Signed-off-by: KAMEZAWA Hiroyuki Acked-by: Daisuke Nishimura -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org