From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 566105F0048 for ; Wed, 20 Oct 2010 00:20:02 -0400 (EDT) Received: from m4.gw.fujitsu.co.jp ([10.0.50.74]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o9K4JurK011283 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Wed, 20 Oct 2010 13:19:57 +0900 Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 6956845DE7A for ; Wed, 20 Oct 2010 13:19:56 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id B91BA45DE6F for ; Wed, 20 Oct 2010 13:19:55 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id EEB21EF800B for ; Wed, 20 Oct 2010 13:19:54 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 7DED1EF8007 for ; Wed, 20 Oct 2010 13:19:54 +0900 (JST) Date: Wed, 20 Oct 2010 13:14:27 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH][memcg+dirtylimit] Fix overwriting global vm dirty limit setting by memcg (Re: [PATCH v3 00/11] memcg: per cgroup dirty page accounting Message-Id: <20101020131427.a4998c33.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20101020122144.47f2b60b.kamezawa.hiroyu@jp.fujitsu.com> References: <1287448784-25684-1-git-send-email-gthelen@google.com> <20101020122144.47f2b60b.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Greg Thelen , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, containers@lists.osdl.org, Andrea Righi , Balbir Singh , Daisuke Nishimura , Minchan Kim , Ciju Rajan K , David Rientjes List-ID: On Wed, 20 Oct 2010 12:21:44 +0900 KAMEZAWA Hiroyuki wrote: > > One bug fix here. > == > From: KAMEZAWA Hiroyuki > > Now, at calculating dirty limit, vm_dirty_param() is called. > This function returns dirty-limit related parameters considering > memory cgroup settings. > > Now, assume that vm_dirty_bytes=100M (global dirty limit) and > memory cgroup has 1G of pages and 40 dirty_ratio, dirtyable memory is > 500MB. > > In this case, global_dirty_limits will consider dirty_limt as > 500 *0.4 = 200MB. This is bad...memory cgroup is not back door. > > This patch limits the return value of vm_dirty_param() considring > global settings. > > Sorry, this one is buggy. I'll post a new one later. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org