From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id C0AF35F004B for ; Tue, 19 Oct 2010 23:50:19 -0400 (EDT) Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o9K3oFNm008093 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Wed, 20 Oct 2010 12:50:15 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id CD70F45DE4E for ; Wed, 20 Oct 2010 12:50:14 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id A940845DE5D for ; Wed, 20 Oct 2010 12:50:14 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 751B61DB8044 for ; Wed, 20 Oct 2010 12:50:14 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id D371B1DB803B for ; Wed, 20 Oct 2010 12:50:13 +0900 (JST) Date: Wed, 20 Oct 2010 12:44:45 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH v3 09/11] memcg: add cgroupfs interface to memcg dirty limits Message-Id: <20101020124445.5a3f9e37.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20101020123110.fd269ab4.nishimura@mxp.nes.nec.co.jp> References: <1287448784-25684-1-git-send-email-gthelen@google.com> <1287448784-25684-10-git-send-email-gthelen@google.com> <20101020123110.fd269ab4.nishimura@mxp.nes.nec.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Daisuke Nishimura Cc: Greg Thelen , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, containers@lists.osdl.org, Andrea Righi , Balbir Singh , Minchan Kim , Ciju Rajan K , David Rientjes List-ID: On Wed, 20 Oct 2010 12:31:10 +0900 Daisuke Nishimura wrote: > On Mon, 18 Oct 2010 17:39:42 -0700 > Greg Thelen wrote: > > > Add cgroupfs interface to memcg dirty page limits: > > Direct write-out is controlled with: > > - memory.dirty_ratio > > - memory.dirty_limit_in_bytes > > > > Background write-out is controlled with: > > - memory.dirty_background_ratio > > - memory.dirty_background_limit_bytes > > > > Other memcg cgroupfs files support 'M', 'm', 'k', 'K', 'g' > > and 'G' suffixes for byte counts. This patch provides the > > same functionality for memory.dirty_limit_in_bytes and > > memory.dirty_background_limit_bytes. > > > > Signed-off-by: Andrea Righi > > Signed-off-by: Balbir Singh > > Signed-off-by: Greg Thelen > > Acked-by: Daisuke Nishimura > > One question: shouldn't we return -EINVAL when writing to dirty(_background)_limit_bytes > a bigger value than that of global one(if any) This should be checked. I'm now writing one add-on. > ? Or do you intentionally > set the input value without comparing it with the global value ? please see my patch sent(memcg+dirtylimit] Fix overwriting global vm dirty limit setting by memcg) IMHO, check at setting value is not helpful because global value can be changed after we set this. My patch checks it at calculating dirtyable bytes. > But, hmm..., IMHO we should check it in __mem_cgroup_dirty_param() or something > not to allow dirty pages more than global limit. > yes. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org