From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kosaki.motohiro@jp.fujitsu.com,
David Rientjes <rientjes@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Mel Gorman <mel@csn.ul.ie>, LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [resend][PATCH 2/2] mm, mem-hotplug: update pcp->stat_threshold when memory hotplug occur
Date: Wed, 20 Oct 2010 11:07:33 +0900 (JST) [thread overview]
Message-ID: <20101020110132.1815.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20101019162940.6918506d.akpm@linux-foundation.org>
> > > @@ -5013,6 +5014,8 @@ int __meminit init_per_zone_wmark_min(void)
> > > min_free_kbytes = 128;
> > > if (min_free_kbytes > 65536)
> > > min_free_kbytes = 65536;
> > > +
> > > + refresh_zone_stat_thresholds();
> > > setup_per_zone_wmarks();
> > > setup_per_zone_lowmem_reserve();
> > > setup_per_zone_inactive_ratio();
> >
> > setup_per_zone_wmarks() could change the min and low watermarks for a zone
> > when refresh_zone_stat_thresholds() would have used the old value.
>
> Indeed.
>
> I could make the obvious fix, but then what I'd have wouldn't be
> sufficiently tested.
Can we review this?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-20 2:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 5:08 [resend][PATCH 1/2] mm, mem-hotplug: recalculate lowmem_reserve " KOSAKI Motohiro
2010-10-19 5:09 ` [resend][PATCH 2/2] mm, mem-hotplug: update pcp->stat_threshold " KOSAKI Motohiro
2010-10-19 14:41 ` Christoph Lameter
2010-10-19 19:11 ` David Rientjes
2010-10-19 23:29 ` Andrew Morton
2010-10-20 2:07 ` KOSAKI Motohiro [this message]
2010-10-20 2:22 ` Andrew Morton
2010-10-20 2:35 ` KOSAKI Motohiro
2010-10-20 2:36 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020110132.1815.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox