* [BUGFIX][PATCH] fix return value of scan_lru_pages in memory unplug
@ 2010-10-13 4:59 KAMEZAWA Hiroyuki
2010-10-13 5:08 ` KOSAKI Motohiro
0 siblings, 1 reply; 3+ messages in thread
From: KAMEZAWA Hiroyuki @ 2010-10-13 4:59 UTC (permalink / raw)
To: linux-mm; +Cc: linux-kernel, akpm, stable
CC'ed to stable tree...maybe all kernel has this bug.
But this may not very critical because we've got no report until now.
==
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
scan_lru_pages returns pfn. So, it's type should be "unsigned long"
not "int".
Note: I guess this has been work until now because memory hotplug tester's
machine has not very big memory....
physical address < 32bit << PAGE_SHIFT.
Reported-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
mm/memory_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: mmotm-1008/mm/memory_hotplug.c
===================================================================
--- mmotm-1008.orig/mm/memory_hotplug.c
+++ mmotm-1008/mm/memory_hotplug.c
@@ -646,7 +646,7 @@ static int test_pages_in_a_zone(unsigned
* Scanning pfn is much easier than scanning lru list.
* Scan pfn from start to end and Find LRU page.
*/
-int scan_lru_pages(unsigned long start, unsigned long end)
+unsigned long scan_lru_pages(unsigned long start, unsigned long end)
{
unsigned long pfn;
struct page *page;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUGFIX][PATCH] fix return value of scan_lru_pages in memory unplug
2010-10-13 4:59 [BUGFIX][PATCH] fix return value of scan_lru_pages in memory unplug KAMEZAWA Hiroyuki
@ 2010-10-13 5:08 ` KOSAKI Motohiro
2010-10-13 5:18 ` [BUGFIX][PATCH v2] " KAMEZAWA Hiroyuki
0 siblings, 1 reply; 3+ messages in thread
From: KOSAKI Motohiro @ 2010-10-13 5:08 UTC (permalink / raw)
To: KAMEZAWA Hiroyuki; +Cc: kosaki.motohiro, linux-mm, linux-kernel, akpm, stable
> CC'ed to stable tree...maybe all kernel has this bug.
> But this may not very critical because we've got no report until now.
Thanks.
>
> ==
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> scan_lru_pages returns pfn. So, it's type should be "unsigned long"
> not "int".
>
> Note: I guess this has been work until now because memory hotplug tester's
> machine has not very big memory....
> physical address < 32bit << PAGE_SHIFT.
>
> Reported-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> ---
> mm/memory_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: mmotm-1008/mm/memory_hotplug.c
> ===================================================================
> --- mmotm-1008.orig/mm/memory_hotplug.c
> +++ mmotm-1008/mm/memory_hotplug.c
> @@ -646,7 +646,7 @@ static int test_pages_in_a_zone(unsigned
> * Scanning pfn is much easier than scanning lru list.
> * Scan pfn from start to end and Find LRU page.
> */
> -int scan_lru_pages(unsigned long start, unsigned long end)
> +unsigned long scan_lru_pages(unsigned long start, unsigned long end)
Also, this can be static. anyway
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [BUGFIX][PATCH v2] fix return value of scan_lru_pages in memory unplug
2010-10-13 5:08 ` KOSAKI Motohiro
@ 2010-10-13 5:18 ` KAMEZAWA Hiroyuki
0 siblings, 0 replies; 3+ messages in thread
From: KAMEZAWA Hiroyuki @ 2010-10-13 5:18 UTC (permalink / raw)
To: KOSAKI Motohiro; +Cc: linux-mm, linux-kernel, akpm, stable
On Wed, 13 Oct 2010 14:08:57 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> Also, this can be static. anyway
> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
yes.
==
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
scan_lru_pages returns pfn. So, it's type should be "unsigned long"
not "int".
Note: I guess this has been work until now because memory hotplug tester's
machine has not very big memory....
physical address < 32bit << PAGE_SHIFT.
Changelog v1->v2:
- make the function static.
Reported-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
mm/memory_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: mmotm-1008/mm/memory_hotplug.c
===================================================================
--- mmotm-1008.orig/mm/memory_hotplug.c
+++ mmotm-1008/mm/memory_hotplug.c
@@ -646,7 +646,7 @@ static int test_pages_in_a_zone(unsigned
* Scanning pfn is much easier than scanning lru list.
* Scan pfn from start to end and Find LRU page.
*/
-int scan_lru_pages(unsigned long start, unsigned long end)
+static unsigned long scan_lru_pages(unsigned long start, unsigned long end)
{
unsigned long pfn;
struct page *page;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-13 5:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-13 4:59 [BUGFIX][PATCH] fix return value of scan_lru_pages in memory unplug KAMEZAWA Hiroyuki
2010-10-13 5:08 ` KOSAKI Motohiro
2010-10-13 5:18 ` [BUGFIX][PATCH v2] " KAMEZAWA Hiroyuki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox