From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 494B76B00D5 for ; Tue, 12 Oct 2010 14:25:45 -0400 (EDT) Date: Tue, 12 Oct 2010 19:25:31 +0100 From: Mel Gorman Subject: Re: [UnifiedV4 00/16] The Unified slab allocator (V4) Message-ID: <20101012182531.GH30667@csn.ul.ie> References: <20101005185725.088808842@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Pekka Enberg Cc: Christoph Lameter , Pekka Enberg , linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Rientjes , npiggin@kernel.dk, yanmin_zhang@linux.intel.com List-ID: On Wed, Oct 06, 2010 at 11:01:35AM +0300, Pekka Enberg wrote: > (Adding more people who've taken interest in slab performance in the > past to CC.) > I have not come even close to reviewing this yet but I made a start on putting it through a series of tests. It fails to build on ppc64 CC mm/slub.o mm/slub.c:1477: warning: 'drain_alien_caches' declared inline after being called mm/slub.c:1477: warning: previous declaration of 'drain_alien_caches' was here mm/slub.c: In function `alloc_shared_caches': mm/slub.c:1748: error: `cpu_info' undeclared (first use in this function) mm/slub.c:1748: error: (Each undeclared identifier is reported only once mm/slub.c:1748: error: for each function it appears in.) mm/slub.c:1748: warning: type defaults to `int' in declaration of `type name' mm/slub.c:1748: warning: type defaults to `int' in declaration of `type name' mm/slub.c:1748: warning: type defaults to `int' in declaration of `type name' mm/slub.c:1748: warning: type defaults to `int' in declaration of `type name' mm/slub.c:1748: error: invalid type argument of `unary *' make[1]: *** [mm/slub.o] Error 1 make: *** [mm] Error 2 I didn't look closely yet but cpu_info is an arch-specific variable. Checking to see if there is a known fix yet before setting aside time to dig deeper. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org