From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
akpm@linux-foundation.org
Subject: Re: RFC: Implement hwpoison on free for soft offlining
Date: Tue, 12 Oct 2010 18:20:04 +0900 (JST) [thread overview]
Message-ID: <20101012181439.ADA9.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <87aamj3k6f.fsf@basil.nowhere.org>
> Andi Kleen <andi@firstfloor.org> writes:
>
> > Here's a somewhat experimental patch to improve soft offlining
> > in hwpoison, but allowing hwpoison on free for not directly
> > freeable page types. It should work for nearly all
> > left over page types that get eventually freed, so this makes
> > soft offlining nearly universal. The only non handleable page
> > types are now pages that never get freed.
> >
> > Drawback: It needs an additional page flag. Cannot set hwpoison
> > directly because that would not be "soft" and cause errors.
>
> Ping? Any comments on this patch?
>
> Except for the page flag use I think it's nearly a no brainer.
> A lot of new soft hwpoison capability for very little additional code.
>
> Has anyone a problem using up a 64bit page flag for that?
To me, it's no problem if this keep 64bit only. IOW, I only dislike to
add 32bit page flags.
Yeah, memory corruption is very crap and i think your effort has a lot
of worth :)
offtopic, I don't think CONFIG_MEMORY_FAILURE and CONFIG_HWPOISON_ON_FREE
are symmetric nor easy understandable. can you please consider naming change?
(example, CONFIG_HWPOISON/CONFIG_HWPOISON_ON_FREE,
CONFIG_MEMORY_FAILURE/CONFIG_MEMORY_FAILURE_SOFT_OFFLINE)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-12 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 22:09 Andi Kleen
2010-10-06 22:09 ` [PATCH] HWPOISON: Implement hwpoison-on-free " Andi Kleen
2010-10-12 12:26 ` Wu Fengguang
2010-10-12 12:37 ` Andi Kleen
2010-10-12 12:41 ` Wu Fengguang
2010-10-12 8:11 ` RFC: Implement hwpoison on free " Andi Kleen
2010-10-12 9:20 ` KOSAKI Motohiro [this message]
2010-10-12 13:14 ` Andi Kleen
2010-10-13 0:15 ` KOSAKI Motohiro
2010-10-15 8:50 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012181439.ADA9.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox