From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 55AB46B006A for ; Fri, 8 Oct 2010 01:17:26 -0400 (EDT) Received: from m5.gw.fujitsu.co.jp ([10.0.50.75]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o985HOnD010956 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Fri, 8 Oct 2010 14:17:24 +0900 Received: from smail (m5 [127.0.0.1]) by outgoing.m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 223D245DE53 for ; Fri, 8 Oct 2010 14:17:24 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (s5.gw.fujitsu.co.jp [10.0.50.95]) by m5.gw.fujitsu.co.jp (Postfix) with ESMTP id EBCFE45DE52 for ; Fri, 8 Oct 2010 14:17:23 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id D6F611DB805B for ; Fri, 8 Oct 2010 14:17:23 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id 7E1EC1DB8043 for ; Fri, 8 Oct 2010 14:17:23 +0900 (JST) Date: Fri, 8 Oct 2010 14:12:01 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH v2] memcg: reduce lock time at move charge (Was Re: [PATCH 04/10] memcg: disable local interrupts in lock_page_cgroup() Message-Id: <20101008141201.c1e3a4e2.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20101007215556.21412ae6.akpm@linux-foundation.org> References: <1286175485-30643-1-git-send-email-gthelen@google.com> <1286175485-30643-5-git-send-email-gthelen@google.com> <20101005160332.GB9515@barrios-desktop> <20101007093545.429fe04a.kamezawa.hiroyu@jp.fujitsu.com> <20101007105456.d86d8092.nishimura@mxp.nes.nec.co.jp> <20101007111743.322c3993.kamezawa.hiroyu@jp.fujitsu.com> <20101007152111.df687a62.kamezawa.hiroyu@jp.fujitsu.com> <20101007162811.c3a35be9.nishimura@mxp.nes.nec.co.jp> <20101007164204.83b207c6.kamezawa.hiroyu@jp.fujitsu.com> <20101007170405.27ed964c.kamezawa.hiroyu@jp.fujitsu.com> <20101007161454.84570cf9.akpm@linux-foundation.org> <20101008133712.2a836331.kamezawa.hiroyu@jp.fujitsu.com> <20101007215556.21412ae6.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: Daisuke Nishimura , Minchan Kim , Greg Thelen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, containers@lists.osdl.org, Andrea Righi , Balbir Singh List-ID: On Thu, 7 Oct 2010 21:55:56 -0700 Andrew Morton wrote: > On Fri, 8 Oct 2010 13:37:12 +0900 KAMEZAWA Hiroyuki wrote: > > > On Thu, 7 Oct 2010 16:14:54 -0700 > > Andrew Morton wrote: > > > > > On Thu, 7 Oct 2010 17:04:05 +0900 > > > KAMEZAWA Hiroyuki wrote: > > > > > > > Now, at task migration among cgroup, memory cgroup scans page table and moving > > > > account if flags are properly set. > > > > > > > > The core code, mem_cgroup_move_charge_pte_range() does > > > > > > > > pte_offset_map_lock(); > > > > for all ptes in a page table: > > > > 1. look into page table, find_and_get a page > > > > 2. remove it from LRU. > > > > 3. move charge. > > > > 4. putback to LRU. put_page() > > > > pte_offset_map_unlock(); > > > > > > > > for pte entries on a 3rd level? page table. > > > > > > > > This pte_offset_map_lock seems a bit long. This patch modifies a rountine as > > > > > > > > for 32 pages: pte_offset_map_lock() > > > > find_and_get a page > > > > record it > > > > pte_offset_map_unlock() > > > > for all recorded pages > > > > isolate it from LRU. > > > > move charge > > > > putback to LRU > > > > for all recorded pages > > > > put_page() > > > > > > The patch makes the code larger, more complex and slower! > > > > > > > Slower ? > > Sure. It walks the same data three times, potentially causing > thrashing in the L1 cache. Hmm, make this 2 times, at least. > It takes and releases locks at a higher frequency. It increases the text size. > But I don't think page_table_lock is a lock which someone can hold so long that 1. find_get_page 2. spin_lock(zone->lock) 3. remove it from LRU 4. lock_page_cgroup() 5. move charge (This means page 5. putback to LRU for 4096/8=1024 pages long. will try to make the routine smarter. But I want to get rid of page_table_lock -> lock_page_cgroup(). Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org