From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id 14F636B0087 for ; Wed, 6 Oct 2010 07:07:57 -0400 (EDT) Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by e7.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o96AqNjh005135 for ; Wed, 6 Oct 2010 06:52:23 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o96B7jhf308214 for ; Wed, 6 Oct 2010 07:07:45 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o96B7jg0019026 for ; Wed, 6 Oct 2010 08:07:45 -0300 Date: Wed, 6 Oct 2010 16:37:39 +0530 From: Balbir Singh Subject: Re: [PATCH 01/10] memcg: add page_cgroup flags for dirty page tracking Message-ID: <20101006110739.GB4195@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <1286175485-30643-1-git-send-email-gthelen@google.com> <1286175485-30643-2-git-send-email-gthelen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1286175485-30643-2-git-send-email-gthelen@google.com> Sender: owner-linux-mm@kvack.org To: Greg Thelen Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, containers@lists.osdl.org, Andrea Righi , KAMEZAWA Hiroyuki , Daisuke Nishimura List-ID: * Greg Thelen [2010-10-03 23:57:56]: > Add additional flags to page_cgroup to track dirty pages > within a mem_cgroup. > > Signed-off-by: KAMEZAWA Hiroyuki > Signed-off-by: Andrea Righi > Signed-off-by: Greg Thelen > --- > include/linux/page_cgroup.h | 23 +++++++++++++++++++++++ > 1 files changed, 23 insertions(+), 0 deletions(-) > > diff --git a/include/linux/page_cgroup.h b/include/linux/page_cgroup.h > index 5bb13b3..b59c298 100644 > --- a/include/linux/page_cgroup.h > +++ b/include/linux/page_cgroup.h > @@ -40,6 +40,9 @@ enum { > PCG_USED, /* this object is in use. */ > PCG_ACCT_LRU, /* page has been accounted for */ > PCG_FILE_MAPPED, /* page is accounted as "mapped" */ > + PCG_FILE_DIRTY, /* page is dirty */ > + PCG_FILE_WRITEBACK, /* page is under writeback */ > + PCG_FILE_UNSTABLE_NFS, /* page is NFS unstable */ > PCG_MIGRATION, /* under page migration */ > }; > > @@ -59,6 +62,10 @@ static inline void ClearPageCgroup##uname(struct page_cgroup *pc) \ > static inline int TestClearPageCgroup##uname(struct page_cgroup *pc) \ > { return test_and_clear_bit(PCG_##lname, &pc->flags); } > > +#define TESTSETPCGFLAG(uname, lname) \ > +static inline int TestSetPageCgroup##uname(struct page_cgroup *pc) \ > + { return test_and_set_bit(PCG_##lname, &pc->flags); } > + > TESTPCGFLAG(Locked, LOCK) > > /* Cache flag is set only once (at allocation) */ > @@ -80,6 +87,22 @@ SETPCGFLAG(FileMapped, FILE_MAPPED) > CLEARPCGFLAG(FileMapped, FILE_MAPPED) > TESTPCGFLAG(FileMapped, FILE_MAPPED) > > +SETPCGFLAG(FileDirty, FILE_DIRTY) > +CLEARPCGFLAG(FileDirty, FILE_DIRTY) > +TESTPCGFLAG(FileDirty, FILE_DIRTY) > +TESTCLEARPCGFLAG(FileDirty, FILE_DIRTY) > +TESTSETPCGFLAG(FileDirty, FILE_DIRTY) > + > +SETPCGFLAG(FileWriteback, FILE_WRITEBACK) > +CLEARPCGFLAG(FileWriteback, FILE_WRITEBACK) > +TESTPCGFLAG(FileWriteback, FILE_WRITEBACK) > + > +SETPCGFLAG(FileUnstableNFS, FILE_UNSTABLE_NFS) > +CLEARPCGFLAG(FileUnstableNFS, FILE_UNSTABLE_NFS) > +TESTPCGFLAG(FileUnstableNFS, FILE_UNSTABLE_NFS) > +TESTCLEARPCGFLAG(FileUnstableNFS, FILE_UNSTABLE_NFS) > +TESTSETPCGFLAG(FileUnstableNFS, FILE_UNSTABLE_NFS) > + > SETPCGFLAG(Migration, MIGRATION) > CLEARPCGFLAG(Migration, MIGRATION) > TESTPCGFLAG(Migration, MIGRATION) Looks good to me Acked-by: Balbir Singh -- Three Cheers, Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org