From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: kosaki.motohiro@jp.fujitsu.com, "Li,
Shaohua" <shaohua.li@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm <linux-mm@kvack.org>,
"riel@redhat.com" <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch]vmscan: protect exectuable page from inactive list scan
Date: Thu, 30 Sep 2010 12:04:07 +0900 (JST) [thread overview]
Message-ID: <20100930120554.2A97.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20100930025750.GA10456@localhost>
> > > > PTE-referenced PageAnon() pages are activated unconditionally a few
> > > > lines further up, so the page_is_file_cache() check filters only shmem
> > > > pages. I doubt this was your intention...?
> > > This is intented. the executable page protect is just to protect
> > > executable file pages. please see 8cab4754d24a0f.
> >
> > 8cab4754d24a0f was using !PageAnon() but your one are using page_is_file_cache.
> > 8cab4754d24a0f doesn't tell us the reason of the change, no?
>
> What if the executable file happen to be on tmpfs? The !PageAnon()
> test also covers that case. The page_is_file_cache() test here seems
> unnecessary. And it looks better to move the VM_EXEC test above the
> SetPageReferenced() line to avoid possible side effects.
Both agree :)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-09-30 3:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 2:57 Shaohua Li
2010-09-29 10:17 ` Johannes Weiner
2010-09-30 0:04 ` Shaohua Li
2010-09-30 2:27 ` KOSAKI Motohiro
2010-09-30 2:57 ` Wu Fengguang
2010-09-30 3:04 ` KOSAKI Motohiro [this message]
2010-09-30 3:20 ` Shaohua Li
2010-09-30 3:32 ` Wu Fengguang
2010-09-30 4:46 ` KOSAKI Motohiro
2010-09-30 5:46 ` Shaohua Li
2010-09-30 6:00 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930120554.2A97.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox