From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Mikael Starvik <starvik@axis.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
David Howells <dhowells@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Roman Zippel <zippel@linux-m68k.org>,
Michal Simek <monstr@monstr.eu>,
Koichi Yasutake <yasutake.koichi@jp.panasonic.com>,
Kyle McMartin <kyle@mcmartin.ca>, Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Paul Mundt <lethal@linux-sh.org>,
"David S. Miller" <davem@davemloft.net>,
Jeff Dike <jdike@addtoit.com>, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] arch: remove __GFP_REPEAT for order-0 allocations
Date: Tue, 28 Sep 2010 14:36:55 -0700 [thread overview]
Message-ID: <20100928143655.4282a001.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1009280344280.11433@chino.kir.corp.google.com>
On Tue, 28 Sep 2010 03:45:10 -0700 (PDT)
David Rientjes <rientjes@google.com> wrote:
> Order-0 allocations, including quicklist_alloc(), are always under
> PAGE_ALLOC_COSTLY_ORDER, so they loop endlessly in the page allocator
> already without the need for __GFP_REPEAT.
That's only true for the current implementation of the page allocator.
If we were to change the page allocator behaviour to not do that (and
we change it daily!) then all those callsites which wanted __GFP_REPEAT
behaviour will get broken. So someone would need to go back and work
out how to unbreak them, if we remembered.
Plus there's presumably some documentary benefit in leaving the
__GFP_REPEATs in there.
Why are those __GFP_REPEATs present at those callsites? What were
developers trying to achieve?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-09-28 21:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 10:45 David Rientjes
2010-09-28 21:36 ` Andrew Morton [this message]
2010-09-28 21:57 ` Russell King - ARM Linux
2010-09-28 22:47 ` David Rientjes
2010-09-28 22:53 ` Andrew Morton
2010-09-28 23:12 ` David Rientjes
2010-09-28 23:40 ` Andrew Morton
2010-09-28 23:52 ` David Rientjes
2010-09-29 0:41 ` Andrew Morton
2010-09-29 1:10 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928143655.4282a001.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jdike@addtoit.com \
--cc=jesper.nilsson@axis.com \
--cc=kyle@mcmartin.ca \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=paulus@samba.org \
--cc=rientjes@google.com \
--cc=rth@twiddle.net \
--cc=schwidefsky@de.ibm.com \
--cc=starvik@axis.com \
--cc=tglx@linutronix.de \
--cc=yasutake.koichi@jp.panasonic.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox