From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 912EE6B004A for ; Fri, 24 Sep 2010 00:21:51 -0400 (EDT) Date: Fri, 24 Sep 2010 12:24:15 +0900 From: Naoya Horiguchi Subject: Re: [PATCH 03/10] hugetlb: redefine hugepage copy functions Message-ID: <20100924032415.GA26639@spritzera.linux.bs1.fc.nec.co.jp> References: <1283908781-13810-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1283908781-13810-4-git-send-email-n-horiguchi@ah.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Christoph Lameter Cc: Andi Kleen , Andrew Morton , Mel Gorman , Wu Fengguang , Jun'ichi Nomura , linux-mm , LKML List-ID: On Thu, Sep 23, 2010 at 11:21:25AM -0500, Christoph Lameter wrote: > On Wed, 8 Sep 2010, Naoya Horiguchi wrote: > > > This patch modifies hugepage copy functions to have only destination > > and source hugepages as arguments for later use. > > The old ones are renamed from copy_{gigantic,huge}_page() to > > copy_user_{gigantic,huge}_page(). > > This naming convention is consistent with that between copy_highpage() > > and copy_user_highpage(). > > Looking at copy_user_highpage(): The vma parameter does not seem to be > used anywhere anymore? The vaddr is used on arches that have virtual > caching. > > Maybe removing the vma parameter would allow to simplify the hugetlb > code? That's right. I'll do this cleanup (although it may be aside from this patchset.) > Reviewed-by: Christoph Lameter Thank you. - Naoya Horiguchi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org