From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id BCE3B6B004A for ; Thu, 9 Sep 2010 00:13:41 -0400 (EDT) Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o894DXs2004858 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Thu, 9 Sep 2010 13:13:33 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id EEF0D45DE57 for ; Thu, 9 Sep 2010 13:13:32 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id C743545DE63 for ; Thu, 9 Sep 2010 13:13:32 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 977E61DB8038 for ; Thu, 9 Sep 2010 13:13:32 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 3D8CDE08001 for ; Thu, 9 Sep 2010 13:13:32 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH 05/10] vmscan: Synchrounous lumpy reclaim use lock_page() instead trylock_page() In-Reply-To: <20100909121547.2e69735a.kamezawa.hiroyu@jp.fujitsu.com> References: <20100909120448.58acc9a6.kamezawa.hiroyu@jp.fujitsu.com> <20100909121547.2e69735a.kamezawa.hiroyu@jp.fujitsu.com> Message-Id: <20100909131211.C93C.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Thu, 9 Sep 2010 13:13:22 +0900 (JST) Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: kosaki.motohiro@jp.fujitsu.com, Mel Gorman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Linux Kernel List , Rik van Riel , Johannes Weiner , Minchan Kim , Wu Fengguang , Andrea Arcangeli , Dave Chinner , Chris Mason , Christoph Hellwig , Andrew Morton List-ID: > On Thu, 9 Sep 2010 12:04:48 +0900 > KAMEZAWA Hiroyuki wrote: > > > On Mon, 6 Sep 2010 11:47:28 +0100 > > Mel Gorman wrote: > > > > > From: KOSAKI Motohiro > > > > > > With synchrounous lumpy reclaim, there is no reason to give up to reclaim > > > pages even if page is locked. This patch uses lock_page() instead of > > > trylock_page() in this case. > > > > > > Signed-off-by: KOSAKI Motohiro > > > Signed-off-by: Mel Gorman > > > > Reviewed-by: KAMEZAWA Hiroyuki > > > Ah......but can't this change cause dead lock ?? Yes, this patch is purely crappy. please drop. I guess I was poisoned by poisonous mushroom of Mario Bros. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org