From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Christoph Lameter <cl@linux.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Wu Fengguang <fengguang.wu@intel.com>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/10] hugetlb: hugepage migration core
Date: Tue, 7 Sep 2010 10:25:23 +0900 [thread overview]
Message-ID: <20100907012522.GA7672@spritzera.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <alpine.DEB.2.00.1009030907080.5633@router.home>
On Fri, Sep 03, 2010 at 09:10:03AM -0500, Christoph Lameter wrote:
> On Fri, 3 Sep 2010, Naoya Horiguchi wrote:
>
> > diff --git v2.6.36-rc2/mm/vmscan.c v2.6.36-rc2/mm/vmscan.c
> > index c391c32..69ce2a3 100644
> > --- v2.6.36-rc2/mm/vmscan.c
> > +++ v2.6.36-rc2/mm/vmscan.c
> > @@ -40,6 +40,7 @@
> > #include <linux/memcontrol.h>
> > #include <linux/delayacct.h>
> > #include <linux/sysctl.h>
> > +#include <linux/hugetlb.h>
> >
> > #include <asm/tlbflush.h>
> > #include <asm/div64.h>
> > @@ -508,6 +509,10 @@ void putback_lru_page(struct page *page)
> >
> > VM_BUG_ON(PageLRU(page));
> >
> > + if (PageHuge(page)) {
> > + put_page(page);
> > + return;
> > + }
> > redo:
> > ClearPageUnevictable(page);
> >
> > @@ -1112,7 +1117,9 @@ int isolate_lru_page(struct page *page)
> > {
> > int ret = -EBUSY;
> >
> > - if (PageLRU(page)) {
> > + if (PageHuge(page) && get_page_unless_zero(compound_head(page)))
> > + ret = 0;
> > + else if (PageLRU(page)) {
> > struct zone *zone = page_zone(page);
> >
> > spin_lock_irq(&zone->lru_lock);
> >
>
> Huge pages are not on the LRU right?
Yes.
> So why use the lru functions for
> them and then not use the lru? Its a bit stranger. The caller must aware
> of the different handling of huge pages since there is no toying around
> with the lru. So just have the caller do a put or get page instead.
So, you mean we should copy migrate_huge_pages() from migrate_pages() and
make two changes on new function
1. unmap_and_move() -> unmap_and_move_huge_page()
2. putback_lru_pages() -> put_page()
, right?
Thanks,
Naoya Horiguchi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-09-07 1:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 4:37 [PATCH 0/10] Hugepage migration (v4) Naoya Horiguchi
2010-09-03 4:37 ` [PATCH 01/10] hugetlb: fix metadata corruption in hugetlb_fault() Naoya Horiguchi
2010-09-03 4:37 ` [PATCH 02/10] hugetlb: add allocate function for hugepage migration Naoya Horiguchi
2010-09-03 4:37 ` [PATCH 03/10] hugetlb: redefine hugepage copy functions Naoya Horiguchi
2010-09-03 4:37 ` [PATCH 04/10] hugetlb: hugepage migration core Naoya Horiguchi
2010-09-03 14:10 ` Christoph Lameter
2010-09-07 1:25 ` Naoya Horiguchi [this message]
2010-09-03 4:37 ` [PATCH 05/10] HWPOISON, hugetlb: add free check to dequeue_hwpoison_huge_page() Naoya Horiguchi
2010-09-03 4:37 ` [PATCH 06/10] hugetlb: move refcounting in hugepage allocation inside hugetlb_lock Naoya Horiguchi
2010-09-03 4:37 ` [PATCH 07/10] HWPOSION, hugetlb: recover from free hugepage error when !MF_COUNT_INCREASED Naoya Horiguchi
2010-09-03 4:37 ` [PATCH 08/10] HWPOISON, hugetlb: soft offlining for hugepage Naoya Horiguchi
2010-09-03 4:37 ` [PATCH 09/10] HWPOISON, hugetlb: fix unpoison " Naoya Horiguchi
2010-09-03 4:37 ` [PATCH 10/10] page-types.c: fix name of unpoison interface Naoya Horiguchi
2010-09-08 1:19 [PATCH 0/10] Hugepage migration (v5) Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 04/10] hugetlb: hugepage migration core Naoya Horiguchi
2010-09-20 11:10 ` Mel Gorman
2010-09-22 4:59 ` Naoya Horiguchi
2010-09-22 8:40 ` Mel Gorman
2010-09-23 16:52 ` Christoph Lameter
2010-09-24 5:58 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100907012522.GA7672@spritzera.linux.bs1.fc.nec.co.jp \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux.com \
--cc=fengguang.wu@intel.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox