linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: "linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.cz>,
	fengguang.wu@intel.com,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	Mel Gorman <mel@csn.ul.ie>,
	andi.kleen@intel.com, Dave Hansen <dave@linux.vnet.ibm.com>
Subject: [PATCH 0/3] memory hotplug: updates and bugfix for is_removable
Date: Mon, 6 Sep 2010 14:40:19 +0900	[thread overview]
Message-ID: <20100906144019.946d3c49.kamezawa.hiroyu@jp.fujitsu.com> (raw)


Problem:

/sys/devices/system/memory/memoryX/removable file shows whether the section
can be offlined or not. Returns "1" if it seems removable.

Now, the file uses a similar logic to one offline_pages() uses.
Problem here is.
 
  - removable detection logics of is_removable() and offline_pages() is
    different from each other.
  - The logic, which check MIGRATE_TYPE, tend to be incorrect once fragmented.
    MIGRATE_TYPE of a pageblock is just a hint, no guarantee.

Then, this patch set does.

  - use the same logic between is_removable() and offline_pages().
  - don't use MIGRATE_TYPE, check the memmap itself directly rather than hint.

Brief patch description:
 1. bugfix for is_removable() check. I think this should be back ported.
 2. bugfix for callback at counting immobile pages.
    I think the old logic rarely hits this bug..so, not necessary to backport.
 3. the unified new logic for is_remobable.

Only patch1 is CCed to stable for now and the patch series itself is onto
mmotm-08-27.

Thanks,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2010-09-06  5:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-06  5:40 KAMEZAWA Hiroyuki [this message]
2010-09-06  5:42 ` [BUGFIX][PATCH 1/3] memory hotplug: fix next block calculation in is_removable KAMEZAWA Hiroyuki
2010-09-06 13:39   ` Mel Gorman
2010-09-06 17:15     ` Hiroyuki Kamezawa
2010-09-07  9:30       ` Mel Gorman
2010-09-06  5:44 ` [PATCH 2/3] memory hotplug: fix set_migratetype_isolate wrong callback result check KAMEZAWA Hiroyuki
2010-09-06  5:47 ` [PATCH 3/3] memory hotplug: use unified logic for is_removable and offline_pages KAMEZAWA Hiroyuki
2010-09-06  9:30   ` Michal Hocko
2010-09-06 13:30     ` Hiroyuki Kamezawa
2010-09-07 13:16       ` Michal Hocko
2010-09-06 13:58   ` Mel Gorman
2010-09-06 23:58     ` KAMEZAWA Hiroyuki
2010-09-07 13:01       ` Mel Gorman
2010-09-07  1:28 ` [PATCH 0/3] memory hotplug: updates and bugfix for is_removable v3 KAMEZAWA Hiroyuki
2010-09-07  1:32   ` [PATCH 1/3] [BUGFIX] memory hotplug: fix next block calculation in is_removable KAMEZAWA Hiroyuki
2010-09-08 11:23     ` Mel Gorman
2010-09-07  1:34   ` [PATCH 2/3][BUGFIX] memory hotplug: fix notifier's return value check KAMEZAWA Hiroyuki
2010-09-07  1:36   ` [PATCH 3/3] memory hotplug: unify is_removable and offline detection code KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100906144019.946d3c49.kamezawa.hiroyu@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi.kleen@intel.com \
    --cc=dave@linux.vnet.ibm.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox