From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 433F56B004D for ; Fri, 3 Sep 2010 03:54:52 -0400 (EDT) Date: Fri, 3 Sep 2010 09:54:38 +0200 From: Michal Hocko Subject: Re: [PATCH 0/2 v2] Make is_mem_section_removable more conformable with offlining code Message-ID: <20100903075437.GB10686@tiehlicka.suse.cz> References: <20100902144500.a0d05b08.kamezawa.hiroyu@jp.fujitsu.com> <20100902082829.GA10265@tiehlicka.suse.cz> <20100902180343.f4232c6e.kamezawa.hiroyu@jp.fujitsu.com> <20100902092454.GA17971@tiehlicka.suse.cz> <20100902131855.GC10265@tiehlicka.suse.cz> <20100902143939.GD10265@tiehlicka.suse.cz> <20100902150554.GE10265@tiehlicka.suse.cz> <20100903121003.e2b8993a.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100903121003.e2b8993a.kamezawa.hiroyu@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Hiroyuki Kamezawa , Wu Fengguang , "linux-mm@kvack.org" , Andrew Morton , "Kleen, Andi" , Haicheng Li , Christoph Lameter , "linux-kernel@vger.kernel.org" , Mel Gorman List-ID: On Fri 03-09-10 12:10:03, KAMEZAWA Hiroyuki wrote: > On Thu, 2 Sep 2010 17:05:54 +0200 > Michal Hocko wrote: > > > extern int mem_online_node(int nid); > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > > index a4cfcdc..2b736ed 100644 > > --- a/mm/memory_hotplug.c > > +++ b/mm/memory_hotplug.c > > @@ -569,16 +569,25 @@ out: > > EXPORT_SYMBOL_GPL(add_memory); > > > > #ifdef CONFIG_MEMORY_HOTREMOVE > > + > > /* > > - * A free page on the buddy free lists (not the per-cpu lists) has PageBuddy > > - * set and the size of the free page is given by page_order(). Using this, > > - * the function determines if the pageblock contains only free pages. > > - * Due to buddy contraints, a free page at least the size of a pageblock will > > - * be located at the start of the pageblock > > + * A free or LRU pages block are removable > > + * Do not use MIGRATE_MOVABLE because it can be insufficient and > > + * other MIGRATE types are tricky. > > */ > > -static inline int pageblock_free(struct page *page) > > -{ > > - return PageBuddy(page) && page_order(page) >= pageblock_order; > > +bool is_page_removable(struct page *page) > > +{ > > + int page_block = 1 << pageblock_order; > > + while (page_block > 0) { > > + if (PageBuddy(page)) { > > + page_block -= page_order(page); > > + } else if (PageLRU(page)) > > + page_block--; > > + else > > + return false; > > + } > > still seems wrong..."page" pointer should be updated. You are right. I should have double checked that (never send patches before leaving from the office...). -- Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org