From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: kosaki.motohiro@jp.fujitsu.com, Ying Han <yinghan@google.com>,
Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Venkatesh Pallipadi <venki@google.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] vmscan: prevent background aging of anon page in no swap system
Date: Tue, 31 Aug 2010 10:18:35 +0900 (JST) [thread overview]
Message-ID: <20100831101456.87D0.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <AANLkTi=NsY9T19rXuBWmeZ3Z2ayA=tHZ1+e=cEXuKVAt@mail.gmail.com>
> Hi, KOSAKI.
>
> On Tue, Aug 31, 2010 at 9:56 AM, KOSAKI Motohiro
> <kosaki.motohiro@jp.fujitsu.com> wrote:
> >> diff --git a/mm/vmscan.c b/mm/vmscan.c
> >> index 1b145e6..0b8a3ce 100644
> >> --- a/mm/vmscan.c
> >> +++ b/mm/vmscan.c
> >> @@ -1747,7 +1747,7 @@ static void shrink_zone(int priority, struct zone *zone,
> >> * Even if we did not try to evict anon pages at all, we want to
> >> * rebalance the anon lru active/inactive ratio.
> >> */
> >> - if (inactive_anon_is_low(zone, sc) && nr_swap_pages > 0)
> >> + if (nr_swap_pges > 0 && inactive_anon_is_low(zone, sc))
> >
> > Sorry, I don't find any difference. What is your intention?
> >
>
> My intention is that smart gcc can compile out inactive_anon_is_low
> call in case of non swap configurable system.
Do you really check it on your gcc? nr_swap_pages is not file scope variable, it's
global variable. afaik, current gcc's link time optimization is not so cool.
Do you have a disassemble list?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-31 1:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-29 15:43 Minchan Kim
2010-08-29 15:49 ` Rik van Riel
2010-08-29 17:45 ` Ying Han
2010-08-29 20:03 ` Rik van Riel
2010-08-29 20:56 ` Ying Han
2010-08-29 21:23 ` Ying Han
2010-08-29 22:26 ` Rik van Riel
2010-08-30 0:18 ` Minchan Kim
2010-08-30 5:40 ` Ying Han
2010-08-30 6:16 ` Minchan Kim
2010-08-31 0:56 ` KOSAKI Motohiro
2010-08-31 1:10 ` Minchan Kim
2010-08-31 1:18 ` KOSAKI Motohiro [this message]
2010-08-31 1:36 ` Minchan Kim
2010-08-31 1:41 ` KOSAKI Motohiro
2010-08-31 0:56 ` KOSAKI Motohiro
2010-08-31 1:23 ` Minchan Kim
2010-08-31 1:38 ` KOSAKI Motohiro
2010-08-31 2:02 ` Minchan Kim
2010-08-31 2:09 ` KOSAKI Motohiro
2010-08-31 3:47 ` Minchan Kim
2010-08-31 2:30 ` Rik van Riel
2010-08-31 3:46 ` Minchan Kim
2010-09-03 21:06 ` Andrew Morton
2010-09-03 21:23 ` Rik van Riel
2010-09-03 21:45 ` Ying Han
2010-09-03 21:47 ` Ying Han
2010-09-03 21:56 ` Andrew Morton
2010-09-04 1:12 ` Venkatesh Pallipadi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831101456.87D0.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=venki@google.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox